Changeset 85873 in webkit

Timestamp:

May 5, 2011 1:30:13 PM (13 years ago)

Author:

tonyg@chromium.org

Message:

2011-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
​https://bugs.webkit.org/show_bug.cgi?id=59448

• http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
• http/tests/misc/resources/webtiming-cross-origin-redirect.html:
• http/tests/misc/webtiming-origins-expected.txt:

2011-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
​https://bugs.webkit.org/show_bug.cgi?id=59448

• page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/resources/webtiming-cross-origin-and-back2.html (modified) (1 diff)
• LayoutTests/http/tests/misc/resources/webtiming-cross-origin-redirect.html (modified) (1 diff)
• LayoutTests/http/tests/misc/webtiming-origins-expected.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/PerformanceTiming.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
+
+        Reviewed by Nate Chapin.
+
+        [Navigation Timing] navigationStart should always be available
+        https://bugs.webkit.org/show_bug.cgi?id=59448
+
+        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
+        * http/tests/misc/resources/webtiming-cross-origin-redirect.html:
+        * http/tests/misc/webtiming-origins-expected.txt:
+
 2011-05-05  Chang Shu  <cshu@webkit.org>
 

trunk/LayoutTests/http/tests/misc/resources/webtiming-cross-origin-and-back2.html

@@ -17 +17 @@
 function performTest() {
     // FIXME: Need a way to synchronize the test so that loadEventEnd is non-zero.
-    var shouldBeZeroList = ["loadEventEnd", "navigationStart", "redirectStart", "redirectEnd", "secureConnectionStart", "unloadEventEnd", "unloadEventStart"];
+    var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "secureConnectionStart", "unloadEventEnd", "unloadEventStart"];
 
     var timingProperties = new Array;

trunk/LayoutTests/http/tests/misc/resources/webtiming-cross-origin-redirect.html

@@ -17 +17 @@
 function performTest() {
     // FIXME: Need a way to synchronize the test so that loadEventEnd is non-zero.
-    var shouldBeZeroList = ["loadEventEnd", "navigationStart", "redirectStart", "redirectEnd", "secureConnectionStart", "unloadEventEnd", "unloadEventStart"];
+    var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "secureConnectionStart", "unloadEventEnd", "unloadEventStart"];
 
     var timingProperties = new Array;

trunk/LayoutTests/http/tests/misc/webtiming-origins-expected.txt

@@ -56 +56 @@
 PASS timing.loadEventEnd is 0
 PASS timing.loadEventStart is non-zero.
-PASS timing.navigationStart is 0
+PASS timing.navigationStart is non-zero.
 PASS timing.redirectEnd is 0
 PASS timing.redirectStart is 0
@@ -91 +91 @@
 PASS timing.loadEventEnd is 0
 PASS timing.loadEventStart is non-zero.
-PASS timing.navigationStart is 0
+PASS timing.navigationStart is non-zero.
 PASS timing.redirectEnd is 0
 PASS timing.redirectStart is 0

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
+
+        Reviewed by Nate Chapin.
+
+        [Navigation Timing] navigationStart should always be available
+        https://bugs.webkit.org/show_bug.cgi?id=59448
+
+        * page/PerformanceTiming.cpp:
+        (WebCore::PerformanceTiming::navigationStart):
+
 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/page/PerformanceTiming.cpp

@@ -96 +96 @@
         return 0;
 
-    if (timing->hasCrossOriginRedirect)
-        return 0;
-
     return toIntegerMilliseconds(timing->navigationStart);
 }