Changeset 86031 in webkit


Ignore:
Timestamp:
May 8, 2011 11:53:32 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-08 Kamil Blank <k.blank@samsung.com>

Reviewed by Antonio Gomes.

Added new commands to be called by ewk_view_editor_command.
Due to this change ewk_view_select_* functions have been removed.
https://bugs.webkit.org/show_bug.cgi?id=60435

  • ewk/ewk_view.cpp: (ewk_view_execute_editor_command):
  • ewk/ewk_view.h:
Location:
trunk/Source/WebKit/efl
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/efl/ChangeLog

    r86014 r86031  
     12011-05-08  Kamil Blank  <k.blank@samsung.com>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        Added new commands to be called by ewk_view_editor_command.
     6        Due to this change ewk_view_select_* functions have been removed.
     7        https://bugs.webkit.org/show_bug.cgi?id=60435
     8
     9        * ewk/ewk_view.cpp:
     10        (ewk_view_execute_editor_command):
     11        * ewk/ewk_view.h:
     12
    1132011-05-07  Tomasz Morawski  <t.morawski@samsung.com>
    214
  • trunk/Source/WebKit/efl/ewk/ewk_view.cpp

    r85741 r86031  
    15491549
    15501550/**
    1551  * Unselects whatever was selected.
    1552  *
    1553  * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
    1554  */
    1555 Eina_Bool ewk_view_select_none(Evas_Object* o)
    1556 {
    1557     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    1558     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    1559     return _ewk_view_editor_command(priv, "Unselect");
    1560 }
    1561 
    1562 /**
    1563  * Selects everything.
    1564  *
    1565  * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
    1566  */
    1567 Eina_Bool ewk_view_select_all(Evas_Object* o)
    1568 {
    1569     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    1570     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    1571     return _ewk_view_editor_command(priv, "SelectAll");
    1572 }
    1573 
    1574 /**
    1575  * Selects the current paragrah.
    1576  *
    1577  * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
    1578  */
    1579 Eina_Bool ewk_view_select_paragraph(Evas_Object* o)
    1580 {
    1581     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    1582     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    1583     return _ewk_view_editor_command(priv, "SelectParagraph");
    1584 }
    1585 
    1586 /**
    1587  * Selects the current sentence.
    1588  *
    1589  * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
    1590  */
    1591 Eina_Bool ewk_view_select_sentence(Evas_Object* o)
    1592 {
    1593     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    1594     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    1595     return _ewk_view_editor_command(priv, "SelectSentence");
    1596 }
    1597 
    1598 /**
    1599  * Selects the current line.
    1600  *
    1601  * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
    1602  */
    1603 Eina_Bool ewk_view_select_line(Evas_Object* o)
    1604 {
    1605     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    1606     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    1607     return _ewk_view_editor_command(priv, "SelectLine");
    1608 }
    1609 
    1610 /**
    1611  * Selects the current word.
    1612  *
    1613  * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
    1614  */
    1615 Eina_Bool ewk_view_select_word(Evas_Object* o)
    1616 {
    1617     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    1618     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    1619     return _ewk_view_editor_command(priv, "SelectWord");
    1620 }
    1621 
    1622 /**
    16231551 * Executes editor command.
    16241552 *
     
    16391567    case EWK_EDITOR_COMMAND_INSERT_TEXT:
    16401568        return _ewk_view_editor_command(priv, "InsertText", value);
     1569    case EWK_EDITOR_COMMAND_SELECT_NONE:
     1570        return _ewk_view_editor_command(priv, "Unselect");
     1571    case EWK_EDITOR_COMMAND_SELECT_ALL:
     1572        return _ewk_view_editor_command(priv, "SelectAll");
     1573    case EWK_EDITOR_COMMAND_SELECT_PARAGRAPH:
     1574        return _ewk_view_editor_command(priv, "SelectParagraph");
     1575    case EWK_EDITOR_COMMAND_SELECT_SENTENCE:
     1576        return _ewk_view_editor_command(priv, "SelectSentence");
     1577    case EWK_EDITOR_COMMAND_SELECT_LINE:
     1578        return _ewk_view_editor_command(priv, "SelectLine");
     1579    case EWK_EDITOR_COMMAND_SELECT_WORD:
     1580        return _ewk_view_editor_command(priv, "SelectWord");
    16411581    default:
    16421582        return EINA_FALSE;
  • trunk/Source/WebKit/efl/ewk/ewk_view.h

    r85295 r86031  
    348348
    349349EAPI char        *ewk_view_selection_get(const Evas_Object *o);
    350 EAPI Eina_Bool    ewk_view_select_none(Evas_Object *o);
    351 EAPI Eina_Bool    ewk_view_select_all(Evas_Object *o);
    352 EAPI Eina_Bool    ewk_view_select_paragraph(Evas_Object *o);
    353 EAPI Eina_Bool    ewk_view_select_sentence(Evas_Object *o);
    354 EAPI Eina_Bool    ewk_view_select_line(Evas_Object *o);
    355 EAPI Eina_Bool    ewk_view_select_word(Evas_Object *o);
    356350
    357351EAPI Eina_Bool    ewk_view_context_menu_forward_event(Evas_Object *o, const Evas_Event_Mouse_Down *ev);
     
    359353enum _Ewk_Editor_Command {
    360354    EWK_EDITOR_COMMAND_INSERT_IMAGE = 0,
    361     EWK_EDITOR_COMMAND_INSERT_TEXT
     355    EWK_EDITOR_COMMAND_INSERT_TEXT,
     356    EWK_EDITOR_COMMAND_SELECT_NONE,
     357    EWK_EDITOR_COMMAND_SELECT_ALL,
     358    EWK_EDITOR_COMMAND_SELECT_PARAGRAPH,
     359    EWK_EDITOR_COMMAND_SELECT_SENTENCE,
     360    EWK_EDITOR_COMMAND_SELECT_LINE,
     361    EWK_EDITOR_COMMAND_SELECT_WORD
    362362};
    363363typedef enum _Ewk_Editor_Command Ewk_Editor_Command;
Note: See TracChangeset for help on using the changeset viewer.