Changeset 86099 in webkit

Timestamp:

May 9, 2011 4:02:04 PM (13 years ago)

Author:

crogers@google.com

Message:

2011-05-09 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add RAII-style DenormalDisabler class to disable denormals which hurt audio performance
​https://bugs.webkit.org/show_bug.cgi?id=60396

No new tests since audio API is not yet implemented.

• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:
• platform/audio/DenormalDisabler.h: Added. (WebCore::DenormalDisabler::DenormalDisabler): (WebCore::DenormalDisabler::~DenormalDisabler): (WebCore::DenormalDisabler::getCSR): (WebCore::DenormalDisabler::setCSR):
• webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::provideInput):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gypi (modified) (1 diff)
• WebCore.xcodeproj/project.pbxproj (modified) (4 diffs)
• platform/audio/DenormalDisabler.h (added)
• webaudio/AudioDestinationNode.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-09  Chris Rogers  <crogers@google.com>
+
+        Reviewed by Kenneth Russell.
+
+        Add RAII-style DenormalDisabler class to disable denormals which hurt audio performance
+        https://bugs.webkit.org/show_bug.cgi?id=60396
+
+        No new tests since audio API is not yet implemented.
+
+        * WebCore.gypi:
+        * WebCore.xcodeproj/project.pbxproj:
+        * platform/audio/DenormalDisabler.h: Added.
+        (WebCore::DenormalDisabler::DenormalDisabler):
+        (WebCore::DenormalDisabler::~DenormalDisabler):
+        (WebCore::DenormalDisabler::getCSR):
+        (WebCore::DenormalDisabler::setCSR):
+        * webaudio/AudioDestinationNode.cpp:
+        (WebCore::AudioDestinationNode::provideInput):
+
 2011-05-09  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/WebCore.gypi

@@ -3648 +3648 @@
             'platform/audio/Cone.cpp',
             'platform/audio/Cone.h',
+            'platform/audio/DenormalDisabler.h',
             'platform/audio/Distance.cpp',
             'platform/audio/Distance.h',

trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

@@ -5736 +5736 @@
                 FD06DFA5134A4DEF006F5D7D /* DefaultAudioDestinationNode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD06DFA3134A4DEF006F5D7D /* DefaultAudioDestinationNode.cpp */; };
                 FD06DFA6134A4DEF006F5D7D /* DefaultAudioDestinationNode.h in Headers */ = {isa = PBXBuildFile; fileRef = FD06DFA4134A4DEF006F5D7D /* DefaultAudioDestinationNode.h */; };
+                FD1660A513787C6D001FFA7B /* DenormalDisabler.h in Headers */ = {isa = PBXBuildFile; fileRef = FD1660A413787C6D001FFA7B /* DenormalDisabler.h */; };
                 FD2DBF1212B048A300ED98C6 /* Accelerate.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FD2DBF0E12B048A300ED98C6 /* Accelerate.framework */; };
                 FD2DBF1312B048A300ED98C6 /* AudioToolbox.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FD2DBF0F12B048A300ED98C6 /* AudioToolbox.framework */; };
@@ -12233 +12234 @@
                 FD06DFA3134A4DEF006F5D7D /* DefaultAudioDestinationNode.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DefaultAudioDestinationNode.cpp; sourceTree = "<group>"; };
                 FD06DFA4134A4DEF006F5D7D /* DefaultAudioDestinationNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DefaultAudioDestinationNode.h; sourceTree = "<group>"; };
+                FD1660A413787C6D001FFA7B /* DenormalDisabler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DenormalDisabler.h; path = webaudio/audio/DenormalDisabler.h; sourceTree = SOURCE_ROOT; };
                 FD2DBF0E12B048A300ED98C6 /* Accelerate.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Accelerate.framework; path = /System/Library/Frameworks/Accelerate.framework; sourceTree = "<absolute>"; };
                 FD2DBF0F12B048A300ED98C6 /* AudioToolbox.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AudioToolbox.framework; path = /System/Library/Frameworks/AudioToolbox.framework; sourceTree = "<absolute>"; };
@@ -19563 +19565 @@
                                 FD31605A12B026F700C1A359 /* Distance.cpp */,
                                 FD31605B12B026F700C1A359 /* Distance.h */,
+                                FD1660A413787C6D001FFA7B /* DenormalDisabler.h */,
                                 FD31605C12B026F700C1A359 /* EqualPowerPanner.cpp */,
                                 FD31605D12B026F700C1A359 /* EqualPowerPanner.h */,
@@ -22742 +22745 @@
                                 37AFFDF71370A0B800E895C0 /* SharedBufferCRLFLineReader.h in Headers */,
                                 379E371713736A6600B9E919 /* QuotedPrintable.h in Headers */,
+                                FD1660A513787C6D001FFA7B /* DenormalDisabler.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;

trunk/Source/WebCore/webaudio/AudioDestinationNode.cpp

@@ -33 +33 @@
 #include "AudioNodeInput.h"
 #include "AudioNodeOutput.h"
+#include "DenormalDisabler.h"
 
 namespace WebCore {
@@ -53 +54 @@
 void AudioDestinationNode::provideInput(AudioBus* destinationBus, size_t numberOfFrames)
 {
+    // We don't want denormals slowing down any of the audio processing
+    // since they can very seriously hurt performance.
+    // This will take care of all AudioNodes because they all process within this scope.
+    DenormalDisabler denormalDisabler;
+    
     context()->setAudioThread(currentThread());