Changeset 86109 in webkit

Timestamp:

May 9, 2011 5:25:55 PM (13 years ago)

Author:

jer.noble@apple.com

Message:

2011-05-08 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
​https://bugs.webkit.org/show_bug.cgi?id=60449

• fullscreen/full-screen-remove-sibling-expected.txt: Added.
• fullscreen/full-screen-remove-sibling.html: Added.

2011-05-08 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
​https://bugs.webkit.org/show_bug.cgi?id=60449

Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to
coalesce anonymous children.

Test: fullscreen/full-screen-remove-sibling.html

• rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fullscreen/full-screen-remove-sibling-expected.txt (added)
• LayoutTests/fullscreen/full-screen-remove-sibling.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-08  Jeremy Noble  <jer.noble@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
+        https://bugs.webkit.org/show_bug.cgi?id=60449
+
+        * fullscreen/full-screen-remove-sibling-expected.txt: Added.
+        * fullscreen/full-screen-remove-sibling.html: Added.
+
 2011-05-09  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-08  Jeremy Noble  <jer.noble@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
+        https://bugs.webkit.org/show_bug.cgi?id=60449
+
+        Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to 
+        coalesce anonymous children.
+
+        Test: fullscreen/full-screen-remove-sibling.html
+
+        * rendering/RenderObject.h:
+        (WebCore::RenderObject::isAnonymousBlock):
+
 2011-05-09  Jeremy Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/rendering/RenderObject.h

@@ -400 +400 @@
         // RenderBlock having a BLOCK or BOX display. Other classes such as RenderTextFragment
         // are not RenderBlocks and will return false. See https://bugs.webkit.org/show_bug.cgi?id=56709. 
-        return m_isAnonymous && (style()->display() == BLOCK || style()->display() == BOX) && style()->styleType() == NOPSEUDO && isRenderBlock() && !isListMarker();
+        return m_isAnonymous && (style()->display() == BLOCK || style()->display() == BOX) && style()->styleType() == NOPSEUDO && isRenderBlock() && !isListMarker()
+#if ENABLE(FULLSCREEN_API)
+            && !isRenderFullScreen()
+#endif
+            ;
     }
     bool isAnonymousColumnsBlock() const { return style()->specifiesColumns() && isAnonymousBlock(); }