Changeset 86171 in webkit


Ignore:
Timestamp:
May 10, 2011 11:12:35 AM (13 years ago)
Author:
tony@chromium.org
Message:

2011-05-10 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=60079

Update the expected results.

  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html:
  • platform/chromium-linux/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-05-10 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=60079

Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
value pair.

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.
Location:
trunk
Files:
1 added
1 deleted
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86170 r86171  
     12011-05-10  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
     6        https://bugs.webkit.org/show_bug.cgi?id=60079
     7
     8        Update the expected results.
     9
     10        * platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
     11        * platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
     12        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
     13        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
     14        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html:
     15        * platform/chromium-linux/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Removed.
     16        * platform/chromium/test_expectations.txt:
     17
    1182011-05-10  Kenji Imasaki  <imasaki@chromium.org>
    219

  • trunk/LayoutTests/platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt

    r85879 r86171  
    88          text run at (0,0) width 417: "This pixel test verifies that we position combining characters properly."
    99      RenderBlock {P} at (0,36) size 784x20
    10         RenderText {#text} at (0,0) size 668x19
    11           text run at (0,0) width 668: "The backslash-looking mark should connect into the the character on the right, not be positioned off to the side."
     10        RenderText {#text} at (0,0) size 679x19
     11          text run at (0,0) width 679: "The backslash-looking mark should connect into the the character on the center, not be positioned off to the side."
    1212      RenderBlock {DIV} at (0,72) size 784x83
    1313        RenderText {#text} at (0,1) size 279x80

  • trunk/LayoutTests/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt

    r85879 r86171  
    88          text run at (0,0) width 417: "This pixel test verifies that we position combining characters properly."
    99      RenderBlock {P} at (0,36) size 784x20
    10         RenderText {#text} at (0,0) size 668x19
    11           text run at (0,0) width 668: "The backslash-looking mark should connect into the the character on the right, not be positioned off to the side."
     10        RenderText {#text} at (0,0) size 679x19
     11          text run at (0,0) width 679: "The backslash-looking mark should connect into the the character on the center, not be positioned off to the side."
    1212      RenderBlock {DIV} at (0,72) size 784x83
    1313        RenderText {#text} at (0,1) size 279x80

  • trunk/LayoutTests/platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

    r77504 r86171  
    88<p>This pixel test verifies that we position combining characters properly.</p>
    99
    10 <p>The backslash-looking mark should connect into the the character on the right, not be positioned off to the side.</p>
     10<p>The backslash-looking mark should connect into the the character on the center, not be positioned off to the side.</p>
    1111<div class=big>क+े = के</div>
    1212<div class=med>क+े = के</div>

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r86151 r86171  
    40064006BUG_HCLAM MAC GPU : compositing/tiling/huge-layer-img.html = FAIL
    40074007
    4008 BUGWK60079 LINUX : platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE
    4009 
    40104008// Flaky
    40114009BUGWK60344 MAC DEBUG : fast/css/counters/complex-before.html = PASS CRASH

  • trunk/Source/WebCore/ChangeLog

    r86169 r86171  
     12011-05-10  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
     6        https://bugs.webkit.org/show_bug.cgi?id=60079
     7
     8        Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
     9        value pair.
     10
     11        * platform/graphics/chromium/HarfbuzzSkia.cpp:
     12        (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.
     13
    1142011-05-10  Anders Carlsson  <andersca@apple.com>
    215

  • trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp

    r77785 r86171  
    139139static HB_Error getOutlinePoint(HB_Font hbFont, HB_Glyph glyph, int flags, hb_uint32 point, HB_Fixed* xPos, HB_Fixed* yPos, hb_uint32* resultingNumPoints)
    140140{
    141     FontPlatformData* font = reinterpret_cast<FontPlatformData*>(hbFont->userData);
    142     SkPaint paint;
    143 
    144     if (flags & HB_ShaperFlag_UseDesignMetrics)
    145         return HB_Err_Invalid_Argument;  // This is requesting pre-hinted positions. We can't support this.
    146 
    147     font->setupPaint(&paint);
    148     paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
    149     uint16_t glyph16 = glyph;
    150     SkPath path;
    151     paint.getTextPath(&glyph16, sizeof(glyph16), 0, 0, &path);
    152     int numPoints = path.getPoints(0, 0);
    153     if (point >= static_cast<unsigned>(numPoints))
    154         return HB_Err_Invalid_SubTable;
    155     SkPoint* points = reinterpret_cast<SkPoint*>(fastMalloc(sizeof(SkPoint) * (point + 1)));
    156     if (!points)
    157         return HB_Err_Invalid_SubTable;
    158     // Skia does let us get a single point from the path.
    159     path.getPoints(points, point + 1);
    160     *xPos = SkiaScalarToHarfbuzzFixed(points[point].fX);
    161     *yPos = SkiaScalarToHarfbuzzFixed(points[point].fY);
    162     *resultingNumPoints = numPoints;
    163     fastFree(points);
    164 
     141    // We cannot provide the right position of outline points from point index.
     142    // Just return HB_Err_Ok with resultingNumPoints = 0 so that harfbuzz
     143    // falls back on using design coordinate value pair.
     144    // See https://bugs.webkit.org/show_bug.cgi?id=60079 for more details.
     145    *resultingNumPoints = 0;
    165146    return HB_Err_Ok;
    166147}
Note: See TracChangeset for help on using the changeset viewer.