Changeset 86237 in webkit


Ignore:
Timestamp:
May 11, 2011 9:16:01 AM (13 years ago)
Author:
Adam Roben
Message:

Turn on strict PassOwnPtr on Windows

Fixes <​http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/PassOwnPtr.h:

Source/WebCore:

  • platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this

file until SimpleFontData::scaledFontData is dealt with on all platforms.

Source/WebKit2:

  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:

(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Use nullptr instead of 0.

Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r86220 r86237  
     12011-05-11  Adam Roben  <aroben@apple.com>
     2
     3        Turn on strict PassOwnPtr on Windows
     4
     5        Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled
     6
     7        Reviewed by Adam Barth.
     8
     9        * wtf/PassOwnPtr.h:
     10
    1112011-05-10  Stephanie Lewis  <slewis@apple.com>
    212

  • trunk/Source/JavaScriptCore/wtf/PassOwnPtr.h

    r86211 r86237  
    3232#include "TypeTraits.h"
    3333
    34 #if !PLATFORM(CHROMIUM)
     34#if !PLATFORM(CHROMIUM) && !PLATFORM(WIN)
    3535// Remove this once we make all WebKit code compatible with stricter rules about PassOwnPtr.
    3636#define LOOSE_PASS_OWN_PTR

  • trunk/Source/WebCore/ChangeLog

    r86234 r86237  
     12011-05-11  Adam Roben  <aroben@apple.com>
     2
     3        Turn on strict PassOwnPtr on Windows
     4
     5        Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled
     6
     7        Reviewed by Adam Barth.
     8
     9        * platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this
     10        file until SimpleFontData::scaledFontData is dealt with on all platforms.
     11
    1122011-05-11  Julien Chaffraix  <jchaffraix@webkit.org>
    213

  • trunk/Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp

    r84101 r86237  
    2828
    2929#include "config.h"
     30
     31// FIXME: Remove this define!
     32#define LOOSE_PASS_OWN_PTR
     33
    3034#include "SimpleFontData.h"
    3135

  • trunk/Source/WebKit2/ChangeLog

    r86231 r86237  
     12011-05-11  Adam Roben  <aroben@apple.com>
     2
     3        Turn on strict PassOwnPtr on Windows
     4
     5        Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled
     6
     7        Reviewed by Adam Barth.
     8
     9        * WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:
     10        (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Use nullptr instead of 0.
     11
    1122011-05-11  Jessie Berlin  <jberlin@apple.com>
    213

  • trunk/Source/WebKit2/WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp

    r85699 r86237  
    7676        if (m_rootLayer) {
    7777            m_rootLayer->removeAllChildren();
    78             m_rootLayer = 0;
     78            m_rootLayer = nullptr;
    7979        }
    8080        return;
Note: See TracChangeset for help on using the changeset viewer.