Changeset 86243 in webkit

Timestamp:

May 11, 2011 9:59:08 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-11 Chang Shu <​cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
​https://bugs.webkit.org/show_bug.cgi?id=60477

Unskip passed tests.

• platform/qt/Skipped:

2011-05-11 Chang Shu <​cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
​https://bugs.webkit.org/show_bug.cgi?id=60477

PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
The value is checked at EventHandler.cpp:2527 (r86166).

Function keyTextForKeyEvent is partially implemented and can be enhanced in
a need-base.

• platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-11  Chang Shu  <cshu@webkit.org>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
+        https://bugs.webkit.org/show_bug.cgi?id=60477
+
+        Unskip passed tests.
+
+        * platform/qt/Skipped:
+
 2011-05-11  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -334 +334 @@
 editing/inserting/insert-div-023.html
 editing/inserting/multiple-lines-selected.html
-editing/inserting/typing-tab-designmode-forms.html
-editing/inserting/typing-tab-designmode.html
 editing/inserting/5994480-2.html
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-11  Chang Shu  <cshu@webkit.org>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
+        https://bugs.webkit.org/show_bug.cgi?id=60477
+
+        PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
+        The value is checked at EventHandler.cpp:2527 (r86166).
+
+        Function keyTextForKeyEvent is partially implemented and can be enhanced in
+        a need-base.
+
+        * platform/qt/PlatformKeyboardEventQt.cpp:
+        (WebCore::keyTextForKeyEvent):
+        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
 2011-05-11  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp

@@ -579 +579 @@
 }
 
+static String keyTextForKeyEvent(const QKeyEvent* event)
+{
+    switch (event->key()) {
+    case Qt::Key_Tab:
+    case Qt::Key_Backtab:
+        if (event->text().isNull())
+            return "\t";
+    }
+    return event->text();
+}
+
 PlatformKeyboardEvent::PlatformKeyboardEvent(QKeyEvent* event)
 {
     const int state = event->modifiers();
     m_type = (event->type() == QEvent::KeyRelease) ? KeyUp : KeyDown;
-    m_text = event->text();
-    m_unmodifiedText = event->text(); // FIXME: not correct
+    m_text = keyTextForKeyEvent(event);
+    m_unmodifiedText = m_text; // FIXME: not correct
     m_keyIdentifier = keyIdentifierForQtKeyCode(event->key());
     m_autoRepeat = event->isAutoRepeat();