Changeset 86291 in webkit

Timestamp:

May 11, 2011 5:29:35 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-11 Zelidrag Hornung <​zelidrag@chromium.org>

Reviewed by David Levin.

Prevented DOMFileSystemBase from imposing file naming restrictions on
external file systems.

​https://bugs.webkit.org/show_bug.cgi?id=60583

There are no new tests for this change since it requires the presence
of external file system provider which is specific to the platform host
process. Chromium implementation will test this within its extension API
test suite.

• fileapi/DOMFileSystemBase.cpp: (WebCore::pathToAbsolutePath): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• fileapi/DOMFileSystemBase.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-11  Zelidrag Hornung  <zelidrag@chromium.org>
+
+        Reviewed by David Levin.
+
+        Prevented DOMFileSystemBase from imposing file naming restrictions on
+        external file systems.
+
+        https://bugs.webkit.org/show_bug.cgi?id=60583
+
+        There are no new tests for this change since it requires the presence
+        of external file system provider which is specific to the platform host
+        process. Chromium implementation will test this within its extension API
+        test suite.
+
+        * fileapi/DOMFileSystemBase.cpp:
+        (WebCore::pathToAbsolutePath):
+        (WebCore::DOMFileSystemBase::getFile):
+        (WebCore::DOMFileSystemBase::getDirectory):
+
 2011-05-11  Antoine Labour  <piman@chromium.org>
 

trunk/Source/WebCore/fileapi/DOMFileSystemBase.cpp

@@ -138 +138 @@
 }
 
-static bool pathToAbsolutePath(const EntryBase* base, String path, String& absolutePath)
+static bool pathToAbsolutePath(AsyncFileSystem::Type type, const EntryBase* base, String path, String& absolutePath)
 {
     ASSERT(base);
@@ -146 +146 @@
     absolutePath = DOMFilePath::removeExtraParentReferences(path);
 
-    if (!DOMFilePath::isValidPath(absolutePath))
+    if ((type == AsyncFileSystem::Temporary || type == AsyncFileSystem::Persistent) && !DOMFilePath::isValidPath(absolutePath))
         return false;
     return true;
@@ -209 +209 @@
 {
     String absolutePath;
-    if (!pathToAbsolutePath(base, path, absolutePath))
+    if (!pathToAbsolutePath(m_asyncFileSystem->type(), base, path, absolutePath))
         return false;
 
@@ -224 +224 @@
 {
     String absolutePath;
-    if (!pathToAbsolutePath(base, path, absolutePath))
+    if (!pathToAbsolutePath(m_asyncFileSystem->type(), base, path, absolutePath))
         return false;