Changeset 86311 in webkit

Timestamp:

May 11, 2011 10:40:20 PM (13 years ago)

Author:

morrita@google.com

Message:

2011-05-10 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
​https://bugs.webkit.org/show_bug.cgi?id=60534

• editing/pasteboard/paste-removing-iframe-expected.txt: Added.
• editing/pasteboard/paste-removing-iframe.html: Added.
• editing/pasteboard/resources/paste-removing-iframe-child.html: Added.

2011-05-10 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
​https://bugs.webkit.org/show_bug.cgi?id=60534

Added missing null check.

Test: editing/pasteboard/paste-removing-iframe.html

• editing/Editor.cpp: (WebCore::Editor::shouldChangeSelection):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/pasteboard/paste-removing-iframe-expected.txt (added)
• LayoutTests/editing/pasteboard/paste-removing-iframe.html (added)
• LayoutTests/editing/pasteboard/resources/paste-removing-iframe-child.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/Editor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-10  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Kent Tamura.
+
+        Crashes if the document inside iframe is removed during pasting some text into it.
+        https://bugs.webkit.org/show_bug.cgi?id=60534
+
+        * editing/pasteboard/paste-removing-iframe-expected.txt: Added.
+        * editing/pasteboard/paste-removing-iframe.html: Added.
+        * editing/pasteboard/resources/paste-removing-iframe-child.html: Added.
+
 2011-05-11  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-10  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Kent Tamura.
+
+        Crashes if the document inside iframe is removed during pasting some text into it.
+        https://bugs.webkit.org/show_bug.cgi?id=60534
+
+        Added missing null check.
+        
+        Test: editing/pasteboard/paste-removing-iframe.html
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::shouldChangeSelection):
+
 2011-05-11  Brian Salomon  <bsalomon@google.com>
 

trunk/Source/WebCore/editing/Editor.cpp

@@ -2788 +2788 @@
 bool Editor::shouldChangeSelection(const VisibleSelection& oldSelection, const VisibleSelection& newSelection, EAffinity affinity, bool stillSelecting) const
 {
-    return client()->shouldChangeSelectedRange(oldSelection.toNormalizedRange().get(), newSelection.toNormalizedRange().get(), affinity, stillSelecting);
+    return client() && client()->shouldChangeSelectedRange(oldSelection.toNormalizedRange().get(), newSelection.toNormalizedRange().get(), affinity, stillSelecting);
 }