Changeset 86331 in webkit

Timestamp:

May 12, 2011 5:32:38 AM (13 years ago)

Author:

rwlbuis@webkit.org

Message:

2011-05-12 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Eric Seidel.

REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
​https://bugs.webkit.org/show_bug.cgi?id=59941

Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.

Test: svg/custom/fill-opacity-update.svg

• rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/custom/fill-opacity-update-expected.png (added)
• LayoutTests/platform/mac/svg/custom/fill-opacity-update-expected.txt (added)
• LayoutTests/svg/custom/fill-opacity-update.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/SVGRenderStyle.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-12  Rob Buis  <rwlbuis@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
+        https://bugs.webkit.org/show_bug.cgi?id=59941
+
+        * svg/custom/fill-opacity-update.svg: Added.
+
 2011-05-10  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-12  Rob Buis  <rwlbuis@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
+        https://bugs.webkit.org/show_bug.cgi?id=59941
+
+        Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.
+
+        Test: svg/custom/fill-opacity-update.svg
+
+        * rendering/style/SVGRenderStyle.cpp:
+        (WebCore::SVGRenderStyle::diff):
+
 2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp

@@ -194 +194 @@
 
     // If fill changes, we just need to repaint. Fill boundaries are not influenced by this, only by the Path, that RenderSVGPath contains.
-    if (fill->paintType != other->fill->paintType || fill->paintColor != other->fill->paintColor || fill->paintUri != other->fill->paintUri)
+    if (fill->paintType != other->fill->paintType || fill->paintColor != other->fill->paintColor
+        || fill->paintUri != other->fill->paintUri || fill->opacity != other->fill->opacity)
         return StyleDifferenceRepaint;