Changeset 86389 in webkit

Timestamp:

May 12, 2011 3:31:56 PM (13 years ago)

Author:

eae@chromium.org

Message:

2011-05-12 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
​https://bugs.webkit.org/show_bug.cgi?id=60640

Pass by const reference instead of by value for consistency reasons.

Refactoring, covered by existing tests.

• rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
• rendering/RenderFlexibleBox.h: Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderFlexibleBox.cpp (modified) (1 diff)
• rendering/RenderFlexibleBox.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-12  Emil A Eklund  <eae@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
+        https://bugs.webkit.org/show_bug.cgi?id=60640
+
+        Pass by const reference instead of by value for consistency reasons.
+
+        Refactoring, covered by existing tests.
+
+        * rendering/RenderFlexibleBox.cpp:
+        (WebCore::RenderFlexibleBox::placeChild):
+        * rendering/RenderFlexibleBox.h:
+        Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead
+
 2011-05-12  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp

@@ -934 +934 @@
 }
 
-void RenderFlexibleBox::placeChild(RenderBox* child, IntPoint location)
+void RenderFlexibleBox::placeChild(RenderBox* child, const IntPoint& location)
 {
     IntRect oldRect = child->frameRect();

trunk/Source/WebCore/rendering/RenderFlexibleBox.h

@@ -51 +51 @@
     virtual bool isStretchingChildren() const { return m_stretchingChildren; }
 
-    void placeChild(RenderBox* child, IntPoint location);
+    void placeChild(RenderBox* child, const IntPoint& location);
 
 protected: