Changeset 86401 in webkit
- Timestamp:
- May 12, 2011 5:06:49 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r86400 r86401 1 2011-05-12 Patrick Gansterer <paroga@webkit.org> 2 3 Reviewed by Darin Adler. 4 5 Rename SimpleFontData::scaledFontData to createScaledFontData 6 https://bugs.webkit.org/show_bug.cgi?id=60723 7 8 * platform/graphics/SimpleFontData.h: 9 * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: 10 * platform/graphics/chromium/SimpleFontDataLinux.cpp: 11 * platform/graphics/freetype/SimpleFontDataFreeType.cpp: 12 * platform/graphics/haiku/SimpleFontDataHaiku.cpp: 13 * platform/graphics/mac/SimpleFontDataMac.mm: 14 * platform/graphics/pango/SimpleFontDataPango.cpp: 15 * platform/graphics/qt/SimpleFontDataQt.cpp: 16 * platform/graphics/win/SimpleFontDataWin.cpp: 17 * platform/graphics/wince/SimpleFontDataWinCE.cpp: 18 * platform/graphics/wx/SimpleFontDataWx.cpp: 19 1 20 2011-05-12 Levi Weintraub <leviw@chromium.org> 2 21 -
trunk/Source/WebCore/platform/graphics/SimpleFontData.h
r86375 r86401 194 194 void commonInit(); 195 195 196 PassOwnPtr<SimpleFontData> scaledFontData(const FontDescription&, float scaleFactor) const;196 PassOwnPtr<SimpleFontData> createScaledFontData(const FontDescription&, float scaleFactor) const; 197 197 198 198 #if (PLATFORM(WIN) && !OS(WINCE)) \ -
trunk/Source/WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp
r86375 r86401 113 113 } 114 114 115 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const115 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 116 116 { 117 117 LOGFONT winFont; … … 128 128 m_derivedFontData = DerivedFontData::create(isCustomFont()); 129 129 if (!m_derivedFontData->smallCaps) 130 m_derivedFontData->smallCaps = scaledFontData(fontDescription, .7);130 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, .7); 131 131 132 132 return m_derivedFontData->smallCaps.get(); … … 138 138 m_derivedFontData = DerivedFontData::create(isCustomFont()); 139 139 if (!m_derivedFontData->emphasisMark) 140 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);140 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 141 141 142 142 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp
r86375 r86401 156 156 } 157 157 158 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const158 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 159 159 { 160 160 const float scaledSize = lroundf(fontDescription.computedSize() * scaleFactor); … … 167 167 m_derivedFontData = DerivedFontData::create(isCustomFont()); 168 168 if (!m_derivedFontData->smallCaps) 169 m_derivedFontData->smallCaps = scaledFontData(fontDescription, smallCapsFraction);169 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, smallCapsFraction); 170 170 171 171 return m_derivedFontData->smallCaps.get(); … … 177 177 m_derivedFontData = DerivedFontData::create(isCustomFont()); 178 178 if (!m_derivedFontData->emphasisMark) 179 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, emphasisMarkFraction);179 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, emphasisMarkFraction); 180 180 181 181 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
r86375 r86401 87 87 } 88 88 89 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const89 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 90 90 { 91 91 return adoptPtr(new SimpleFontData(FontPlatformData(cairo_scaled_font_get_font_face(m_platformData.scaledFont()), … … 100 100 // FIXME: I think we want to ask FontConfig for the right font again. 101 101 if (!m_derivedFontData->smallCaps) 102 m_derivedFontData->smallCaps = scaledFontData(fontDescription, .7);102 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, .7); 103 103 104 104 return m_derivedFontData->smallCaps.get(); … … 110 110 m_derivedFontData = DerivedFontData::create(isCustomFont()); 111 111 if (!m_derivedFontData->emphasisMark) 112 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);112 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 113 113 114 114 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/haiku/SimpleFontDataHaiku.cpp
r86375 r86401 67 67 } 68 68 69 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const69 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 70 70 { 71 71 FontDescription desc = FontDescription(fontDescription); … … 80 80 m_derivedFontData = DerivedFontData::create(isCustomFont()); 81 81 if (!m_derivedFontData->smallCaps) 82 m_derivedFontData->smallCaps = scaledFontData(fontDescription, .7);82 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, .7); 83 83 84 84 return m_derivedFontData->smallCaps.get(); … … 90 90 m_derivedFontData = DerivedFontData::create(isCustomFont()); 91 91 if (!m_derivedFontData->emphasisMark) 92 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);92 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 93 93 94 94 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
r86375 r86401 297 297 } 298 298 299 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const299 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 300 300 { 301 301 if (isCustomFont()) { … … 339 339 m_derivedFontData = DerivedFontData::create(isCustomFont()); 340 340 if (!m_derivedFontData->smallCaps) 341 m_derivedFontData->smallCaps = scaledFontData(fontDescription, smallCapsFontSizeMultiplier);341 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, smallCapsFontSizeMultiplier); 342 342 343 343 return m_derivedFontData->smallCaps.get(); … … 349 349 m_derivedFontData = DerivedFontData::create(isCustomFont()); 350 350 if (!m_derivedFontData->emphasisMark) 351 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5f);351 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5f); 352 352 353 353 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/pango/SimpleFontDataPango.cpp
r86375 r86401 85 85 } 86 86 87 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const87 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 88 88 { 89 89 FontDescription desc = FontDescription(fontDescription); … … 98 98 m_derivedFontData = DerivedFontData::create(isCustomFont()); 99 99 if (!m_derivedFontData->smallCaps) 100 m_derivedFontData->smallCaps = scaledFontData(fontDescription, .7);100 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, .7); 101 101 102 102 return m_derivedFontData->smallCaps.get(); … … 108 108 m_derivedFontData = DerivedFontData::create(isCustomFont()); 109 109 if (!m_derivedFontData->emphasisMark) 110 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);110 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 111 111 112 112 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp
r86375 r86401 72 72 } 73 73 74 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const74 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 75 75 { 76 76 const float scaledSize = lroundf(fontDescription.computedSize() * scaleFactor); … … 83 83 m_derivedFontData = DerivedFontData::create(isCustomFont()); 84 84 if (!m_derivedFontData->smallCaps) 85 m_derivedFontData->smallCaps = scaledFontData(fontDescription, smallCapsFraction);85 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, smallCapsFraction); 86 86 87 87 return m_derivedFontData->smallCaps.get(); … … 93 93 m_derivedFontData = DerivedFontData::create(isCustomFont()); 94 94 if (!m_derivedFontData->emphasisMark) 95 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, emphasisMarkFraction);95 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, emphasisMarkFraction); 96 96 97 97 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp
r86375 r86401 109 109 } 110 110 111 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const111 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 112 112 { 113 113 float scaledSize = scaleFactor * m_platformData.size(); … … 130 130 m_derivedFontData = DerivedFontData::create(isCustomFont()); 131 131 if (!m_derivedFontData->smallCaps) 132 m_derivedFontData->smallCaps = scaledFontData(fontDescription, cSmallCapsFontSizeMultiplier);132 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, cSmallCapsFontSizeMultiplier); 133 133 134 134 return m_derivedFontData->smallCaps.get(); … … 140 140 m_derivedFontData = DerivedFontData::create(isCustomFont()); 141 141 if (!m_derivedFontData->emphasisMark) 142 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);142 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 143 143 144 144 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/wince/SimpleFontDataWinCE.cpp
r86375 r86401 64 64 } 65 65 66 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const66 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 67 67 { 68 68 FontDescription fontDesc(fontDescription); … … 81 81 m_derivedFontData = DerivedFontData::create(isCustomFont()); 82 82 if (!m_derivedFontData->smallCaps) 83 m_derivedFontData->smallCaps = scaledFontData(fontDescription, .7);83 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, .7); 84 84 85 85 return m_derivedFontData->smallCaps.get(); … … 91 91 m_derivedFontData = DerivedFontData::create(isCustomFont()); 92 92 if (!m_derivedFontData->emphasisMark) 93 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);93 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 94 94 95 95 return m_derivedFontData->emphasisMark.get(); -
trunk/Source/WebCore/platform/graphics/wx/SimpleFontDataWx.cpp
r86375 r86401 91 91 } 92 92 93 PassOwnPtr<SimpleFontData> SimpleFontData:: scaledFontData(const FontDescription& fontDescription, float scaleFactor) const93 PassOwnPtr<SimpleFontData> SimpleFontData::createScaledFontData(const FontDescription& fontDescription, float scaleFactor) const 94 94 { 95 95 FontDescription desc = FontDescription(fontDescription); … … 104 104 m_derivedFontData = DerivedFontData::create(isCustomFont()); 105 105 if (!m_derivedFontData->smallCaps) 106 m_derivedFontData->smallCaps = scaledFontData(fontDescription, .7);106 m_derivedFontData->smallCaps = createScaledFontData(fontDescription, .7); 107 107 108 108 return m_derivedFontData->smallCaps.get(); … … 114 114 m_derivedFontData = DerivedFontData::create(isCustomFont()); 115 115 if (!m_derivedFontData->emphasisMark) 116 m_derivedFontData->emphasisMark = scaledFontData(fontDescription, .5);116 m_derivedFontData->emphasisMark = createScaledFontData(fontDescription, .5); 117 117 118 118 return m_derivedFontData->emphasisMark.get();
Note: See TracChangeset
for help on using the changeset viewer.