Changeset 86551 in webkit

Timestamp:

May 16, 2011 2:50:41 AM (13 years ago)

Author:

loislo@chromium.org

Message:

2011-05-15 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

• inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

• platform/qt/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/InspectorFrontendHost.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-16  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=60858
+
+        * platform/qt/Skipped:
+
 2011-05-16  Gavin Barraclough  <barraclough@apple.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -107 +107 @@
 inspector/debugger/event-listener-breakpoints.html
 inspector/debugger/xhr-breakpoints.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=60616
-inspector/console/console-long-eval-crash.html
 
 # https://bugs.webkit.org/show_bug.cgi?id=40300

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-15  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=60858
+
+        The client may be gone when sendMessageToBackend() is called.
+
+        * inspector/InspectorFrontendHost.cpp:
+        (WebCore::InspectorFrontendHost::sendMessageToBackend):
+
 2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp

@@ -243 +243 @@
 void InspectorFrontendHost::sendMessageToBackend(const String& message)
 {
-    m_client->sendMessageToBackend(message);
+    if (m_client)
+        m_client->sendMessageToBackend(message);
 }