Changeset 86555 in webkit

Timestamp:

May 16, 2011 3:58:27 AM (13 years ago)

Author:

Nikolas Zimmermann

Message:

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Switch from Vector<UChar> to StringBuilder in dom/
​https://bugs.webkit.org/show_bug.cgi?id=57843

Incorporate comment from Darin/Andreas.

• dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i]. (WebCore::convertPropertyNameToAttributeName): Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DatasetDOMStringMap.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Not reviewed.
+
+        Switch from Vector<UChar> to StringBuilder in dom/
+        https://bugs.webkit.org/show_bug.cgi?id=57843
+
+        Incorporate comment from Darin/Andreas.
+
+        * dom/DatasetDOMStringMap.cpp:
+        (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i].
+        (WebCore::convertPropertyNameToAttributeName): Ditto.
+
 2011-05-16  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/dom/DatasetDOMStringMap.cpp

@@ -58 +58 @@
     unsigned length = name.length();
     for (unsigned i = 5; i < length; ++i) {
-        if (characters[i] != '-')
-            stringBuilder.append(characters[i]);
+        UChar character = characters[i];
+        if (character != '-')
+            stringBuilder.append(character);
         else {
             if ((i + 1 < length) && isASCIILower(characters[i + 1])) {
@@ -65 +66 @@
                 ++i;
             } else
-                stringBuilder.append(characters[i]);
+                stringBuilder.append(character);
         }
     }
@@ -122 +123 @@
         if (isASCIIUpper(character)) {
             builder.append('-');
-            builder.append(toASCIILower(characters[i]));
+            builder.append(toASCIILower(character));
         } else
             builder.append(character);