Changeset 86580 in webkit


Ignore:
Timestamp:
May 16, 2011 9:54:15 AM (13 years ago)
Author:
andersca@apple.com
Message:

2011-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Silverlight: Selection via keyboard selects the entire plugin instead of the contents of a TextBox
https://bugs.webkit.org/show_bug.cgi?id=60898
<rdar://problem/9309903>

Special-case Command-A and always return true, indicating that the plug-in handled the event.
This matches WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r86578 r86580  
     12011-05-16  Anders Carlsson  <andersca@apple.com>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        Silverlight: Selection via keyboard selects the entire plugin instead of the contents of a TextBox
     6        https://bugs.webkit.org/show_bug.cgi?id=60898
     7        <rdar://problem/9309903>
     8
     9        Special-case Command-A and always return true, indicating that the plug-in handled the event.
     10        This matches WebKit1.
     11
     12        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
     13        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
     14
    1152011-05-16  Anders Carlsson  <andersca@apple.com>
    216
  • trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm

    r85962 r86580  
    760760    // This leads to bugs such as <rdar://problem/8740926>. We work around this by returning false
    761761    // if the keyboard event has the command modifier pressed.
    762     if (keyboardEvent.metaKey())
     762    // However, for command-A (the shortcurt for 'Select All' we will always return true, since we don't
     763    // want the entire page to be selected if the focus is in a plug-in text field (see <rdar://problem/9309903>).
     764    if (keyboardEvent.metaKey()) {
     765        if (keyboardEvent.text() == "a")
     766            return true;
     767
    763768        return false;
     769    }
    764770
    765771    return handled;
Note: See TracChangeset for help on using the changeset viewer.