Changeset 86611 in webkit

Timestamp:

May 16, 2011 3:05:30 PM (13 years ago)

Author:

robert@webkit.org

Message:

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

​https://bugs.webkit.org/show_bug.cgi?id=60838

• platform/gtk/Skipped:
• platform/qt/Skipped:

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

​https://bugs.webkit.org/show_bug.cgi?id=60838

The unix test plugin needs to call the test's NPP_URLNotify
rather than the browsers.

• DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_url_notify):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-16  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Anders Carlsson.
+
+        [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
+
+        https://bugs.webkit.org/show_bug.cgi?id=60838
+
+        * platform/gtk/Skipped:
+        * platform/qt/Skipped:
+
 2011-05-16  Dan Bernstein  <mitz@apple.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -157 +157 @@
 # https://bugs.webkit.org/show_bug.cgi?id=31433
 plugins/document-open.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=60838
-plugins/get-url-notify-with-url-that-fails-to-load.html
 
 # https://bugs.webkit.org/show_bug.cgi?id=37574

trunk/LayoutTests/platform/qt/Skipped

@@ -360 +360 @@
 # ---- to be reviewed
 http/tests/plugins/plugin-document-has-focus.html
-
-# Crashes on the buildbot.
-plugins/get-url-notify-with-url-that-fails-to-load.html
 
 # [Qt] plugins/keyboard-events.html fails after r72717 

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-16  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Anders Carlsson.
+
+        [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
+
+        https://bugs.webkit.org/show_bug.cgi?id=60838
+
+        The unix test plugin needs to call the test's NPP_URLNotify
+        rather than the browsers.
+
+        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
+        (webkit_test_plugin_url_notify):
+
 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Tools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp

@@ -318 +318 @@
 {
     PluginObject* obj = static_cast<PluginObject*>(instance->pdata);
+    if (obj->pluginTest->NPP_URLNotify(url, reason, notifyData))
+        return;
 
     if (obj->onURLNotify)