Changeset 86649 in webkit

Timestamp:

May 16, 2011 6:42:14 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
​https://bugs.webkit.org/show_bug.cgi?id=60935

This test case triggers the ASSERT.

• fast/parser/append-child-followed-by-document-write-expected.txt: Added.
• fast/parser/append-child-followed-by-document-write.html: Added.

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
​https://bugs.webkit.org/show_bug.cgi?id=60935

The ASSERT is invalid when the parser is in the initial state and the
document is non-empty, which is strange but not impossible.

Test: fast/parser/append-child-followed-by-document-write.html

• dom/Document.cpp: (WebCore::Document::setCompatibilityMode):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/append-child-followed-by-document-write-expected.txt (added)
• LayoutTests/fast/parser/append-child-followed-by-document-write.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove bogus ASSERT in Document::setCompatibilityMode
+        https://bugs.webkit.org/show_bug.cgi?id=60935
+
+        This test case triggers the ASSERT.
+
+        * fast/parser/append-child-followed-by-document-write-expected.txt: Added.
+        * fast/parser/append-child-followed-by-document-write.html: Added.
+
 2011-05-16  Ian Henderson  <ianh@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove bogus ASSERT in Document::setCompatibilityMode
+        https://bugs.webkit.org/show_bug.cgi?id=60935
+
+        The ASSERT is invalid when the parser is in the initial state and the
+        document is non-empty, which is strange but not impossible.
+
+        Test: fast/parser/append-child-followed-by-document-write.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::setCompatibilityMode):
+
 2011-05-16  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -654 +654 @@
     if (m_compatibilityModeLocked || mode == m_compatibilityMode)
         return;
-    ASSERT(!documentElement() && !m_styleSheets->length());
+    ASSERT(!m_styleSheets->length());
     bool wasInQuirksMode = inQuirksMode();
     m_compatibilityMode = mode;