Changeset 86719 in webkit


Ignore:
Timestamp:
May 17, 2011 4:39:57 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86668.
http://trac.webkit.org/changeset/86668
https://bugs.webkit.org/show_bug.cgi?id=61001

It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
#webkit).

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
Location:
trunk/Source/WebKit2
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r86718 r86719  
     12011-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r86668.
     4        http://trac.webkit.org/changeset/86668
     5        https://bugs.webkit.org/show_bug.cgi?id=61001
     6
     7        It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
     8        #webkit).
     9
     10        * UIProcess/API/qt/qgraphicswkview.cpp:
     11        * UIProcess/API/qt/qgraphicswkview.h:
     12        * UIProcess/API/qt/qwkpage.cpp:
     13        (QWKPagePrivate::createDrawingAreaProxy):
     14
    1152011-05-17  Brian Weinstein  <bweinstein@apple.com>
    216
  • trunk/Source/WebKit2/UIProcess/API/qt/qgraphicswkview.cpp

    r86668 r86719  
    2222#include "qgraphicswkview.h"
    2323
     24#include "ChunkedUpdateDrawingAreaProxy.h"
    2425#include "IntSize.h"
    2526#include "RunLoop.h"
    2627#include "TiledDrawingAreaProxy.h"
     28#include "UpdateChunk.h"
    2729#include "WKAPICast.h"
    2830#include "qwkpage.h"
  • trunk/Source/WebKit2/UIProcess/API/qt/qgraphicswkview.h

    r86668 r86719  
    2727
    2828public:
    29     enum BackingStoreType { Simple, Tiled };
     29    enum BackingStoreType { Simple, Tiled, Impl };
    3030    QGraphicsWKView(QWKContext* context, BackingStoreType backingStoreType = Simple, QGraphicsItem* parent = 0);
    3131
  • trunk/Source/WebKit2/UIProcess/API/qt/qwkpage.cpp

    r86668 r86719  
    2525#include "qwkpreferences_p.h"
    2626
     27#include "ChunkedUpdateDrawingAreaProxy.h"
    2728#include "ClientImpl.h"
    2829#include "DrawingAreaProxyImpl.h"
     
    138139        return TiledDrawingAreaProxy::create(wkView, page.get());
    139140#endif
    140     return DrawingAreaProxyImpl::create(page.get());
     141    if (backingStoreType == QGraphicsWKView::Impl)
     142        return DrawingAreaProxyImpl::create(page.get());
     143    return ChunkedUpdateDrawingAreaProxy::create(wkView, page.get());
    141144}
    142145
Note: See TracChangeset for help on using the changeset viewer.