Changeset 86748 in webkit

Timestamp:

May 18, 2011 3:45:07 AM (13 years ago)

Author:

inferno@chromium.org

Message:

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Schulze.

Tests that we do not crash when trying to access a removed
smil element in animated elements list.
​https://bugs.webkit.org/show_bug.cgi?id=60980

• svg/animations/smil-element-not-removed-crash-expected.txt: Added.
• svg/animations/smil-element-not-removed-crash.html: Added.

2011-05-18 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Schulze.

When SMIL element is getting removed, make sure to remove it
from target's animation elements list.
​https://bugs.webkit.org/show_bug.cgi?id=60980

Test: svg/animations/smil-element-not-removed-crash.html

• svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::~SVGSMILElement):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/animations/smil-element-not-removed-crash-expected.txt (added)
• LayoutTests/svg/animations/smil-element-not-removed-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/animation/SVGSMILElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-18  Abhishek Arya  <inferno@chromium.org>
+
+        Reviewed by Dirk Schulze.
+
+        Tests that we do not crash when trying to access a removed
+        smil element in animated elements list.
+        https://bugs.webkit.org/show_bug.cgi?id=60980
+
+        * svg/animations/smil-element-not-removed-crash-expected.txt: Added.
+        * svg/animations/smil-element-not-removed-crash.html: Added.
+
 2011-05-18  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-18  Abhishek Arya  <inferno@chromium.org>
+
+        Reviewed by Dirk Schulze.
+
+        When SMIL element is getting removed, make sure to remove it
+        from target's animation elements list.
+        https://bugs.webkit.org/show_bug.cgi?id=60980
+
+        Test: svg/animations/smil-element-not-removed-crash.html
+
+        * svg/animation/SVGSMILElement.cpp:
+        (WebCore::SVGSMILElement::~SVGSMILElement):
+
 2011-05-18  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp

@@ -142 +142 @@
     if (m_timeContainer)
         m_timeContainer->unschedule(this);
+    if (m_targetElement)
+        document()->accessSVGExtensions()->removeAnimationElementFromTarget(this, m_targetElement);
 }