Changeset 86776 in webkit

Timestamp:

May 18, 2011 10:47:25 AM (13 years ago)

Author:

arv@chromium.org

Message:

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
​https://bugs.webkit.org/show_bug.cgi?id=56606

This tests that clicking on a label for an input generates a click event on the input
with the same coordinates as the original click.

• fast/events/simulated-click-coords-expected.txt: Added.
• fast/events/simulated-click-coords.html: Added.

2011-05-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
​https://bugs.webkit.org/show_bug.cgi?id=56606

This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
is a mouse event.

This makes us match Firefox and IE.

Test: fast/events/simulated-click-coords.html

• dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/simulated-click-coords-expected.txt (added)
• LayoutTests/fast/events/simulated-click-coords.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/MouseEvent.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-18  Erik Arvidsson  <arv@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        event.clientX/clientY is 0/0 in a click generated through a label
+        https://bugs.webkit.org/show_bug.cgi?id=56606
+
+        This tests that clicking on a label for an input generates a click event on the input
+        with the same coordinates as the original click.
+
+        * fast/events/simulated-click-coords-expected.txt: Added.
+        * fast/events/simulated-click-coords.html: Added.
+
 2011-05-18  Rob Buis  <rbuis@rim.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-18  Erik Arvidsson  <arv@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        event.clientX/clientY is 0/0 in a click generated through a label
+        https://bugs.webkit.org/show_bug.cgi?id=56606
+
+        This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
+        is a mouse event.
+
+        This makes us match Firefox and IE.
+
+        Test: fast/events/simulated-click-coords.html
+
+        * dom/MouseEvent.cpp:
+        (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
+
 2011-05-18  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/Source/WebCore/dom/MouseEvent.cpp

@@ -151 +151 @@
     }
     setUnderlyingEvent(underlyingEvent);
+
+    if (this->underlyingEvent() && this->underlyingEvent()->isMouseEvent()) {
+        MouseEvent* mouseEvent = static_cast<MouseEvent*>(this->underlyingEvent());
+        m_screenX = mouseEvent->screenX();
+        m_screenY = mouseEvent->screenY();
+        initCoordinates(mouseEvent->clientX(), mouseEvent->clientY());
+    }
 }