Changeset 86781 in webkit


Ignore:
Timestamp:
May 18, 2011 12:30:48 PM (13 years ago)
Author:
inferno@chromium.org
Message:

2011-05-18 Abhishek Arya <inferno@chromium.org>

Reviewed by Beth Dakin.

Tests that we do not crash when prematurely calling removeChild,
followed by destroy call on table caption.
https://bugs.webkit.org/show_bug.cgi?id=61083

  • fast/table/table-captions-child-visible-crash-expected.txt: Added.
  • fast/table/table-captions-child-visible-crash.html: Added.

2011-05-18 Abhishek Arya <inferno@chromium.org>

Reviewed by Beth Dakin.

Remove removeChild on table caption since destroy call
already does that.
https://bugs.webkit.org/show_bug.cgi?id=61083

Test: fast/table/table-captions-child-visible-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcCaption):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r86777 r86781  
     12011-05-18  Abhishek Arya  <inferno@chromium.org>
     2
     3        Reviewed by Beth Dakin.
     4
     5        Tests that we do not crash when prematurely calling removeChild,
     6        followed by destroy call on table caption.
     7        https://bugs.webkit.org/show_bug.cgi?id=61083
     8
     9        * fast/table/table-captions-child-visible-crash-expected.txt: Added.
     10        * fast/table/table-captions-child-visible-crash.html: Added.
     11
    1122011-05-18  Chang Shu  <cshu@webkit.org>
    213
  • trunk/Source/WebCore/ChangeLog

    r86780 r86781  
     12011-05-18  Abhishek Arya  <inferno@chromium.org>
     2
     3        Reviewed by Beth Dakin.
     4
     5        Remove removeChild on table caption since destroy call
     6        already does that.
     7        https://bugs.webkit.org/show_bug.cgi?id=61083
     8
     9        Test: fast/table/table-captions-child-visible-crash.html
     10
     11        * rendering/RenderTable.cpp:
     12        (WebCore::RenderTable::recalcCaption):
     13
    1142011-05-18  Evan Martin  <evan@chromium.org>
    215
  • trunk/Source/WebCore/rendering/RenderTable.cpp

    r86705 r86781  
    702702        m_caption->setNeedsLayout(true);
    703703    } else {
    704         // Detach the child from the table.
    705         const RenderBlock* block = static_cast<const RenderBlock*>(this);
    706         const_cast<RenderBlock*>(block)->removeChild(caption);
    707 
    708704        // Make sure to null out the child's renderer.
    709705        if (Node* node = caption->node())
Note: See TracChangeset for help on using the changeset viewer.