Changeset 86791 in webkit


Ignore:
Timestamp:
May 18, 2011 2:40:16 PM (13 years ago)
Author:
rwlbuis@webkit.org
Message:

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60721

Change <marker> renderer creation behaviour to always create the renderer. This fixes
the problem that no marker is rendered when display=none is set on the <marker>. The
specification states that display=none should have no influence on <marker> usage:
"The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
elements are available for referencing even when the ‘display’ property on the ‘marker’
element or any of its ancestors is set to none."

Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg

svg/custom/painting-marker-07-f-inherit.svg

  • svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::rendererIsNeeded):

2011-05-18 Rob Buis <​rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60721

Test cases where display=none is set on <marker>, i.e. directly or through ancestor.

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
  • platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
  • svg/custom/painting-marker-07-f-inherit.svg: Added.
Location:
trunk
Files:
6 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86790 r86791  
     12011-05-18  Rob Buis  <rbuis@rim.com>
     2
     3        Reviewed by Nikolas Zimmermann.
     4
     5        Marker test from ietestcenter fails
     6        https://bugs.webkit.org/show_bug.cgi?id=60721
     7
     8        Test cases where display=none is set on <marker>, i.e. directly or through ancestor.
     9
     10        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
     11        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
     12        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
     13        * platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
     14        * platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
     15        * svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
     16        * svg/custom/painting-marker-07-f-inherit.svg: Added.
     17
    1182011-05-18  Alexis Menard  <alexis.menard@openbossa.org>, Simon Hausmann  <simon.hausmann@nokia.com>
    219

  • trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt

    r81168 r86791  
    5959            chunk 1 text run 7 at (177.47,180.00) startOffset 20 endOffset 21 width 11.67: "G"
    6060            chunk 1 text run 8 at (189.05,180.00) startOffset 21 endOffset 26 width 38.35: "Angle"
     61      RenderSVGResourceMarker {marker} [id="m"] [markerUnits=strokeWidth] [ref at (0,0)] [angle=1.80]
    6162    RenderSVGContainer {g} at (10,314) size 227x33
    6263      RenderSVGText {text} at (10,314) size 227x33 contains 1 chunk(s)

  • trunk/Source/WebCore/ChangeLog

    r86790 r86791  
     12011-05-18  Rob Buis  <rbuis@rim.com>
     2
     3        Reviewed by Nikolas Zimmermann.
     4
     5        Marker test from ietestcenter fails
     6        https://bugs.webkit.org/show_bug.cgi?id=60721
     7
     8        Change <marker> renderer creation behaviour to always create the renderer. This fixes
     9        the problem that no marker is rendered when display=none is set on the <marker>. The
     10        specification states that display=none should have no influence on <marker> usage:
     11        "The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
     12        elements are available for referencing even when the ‘display’ property on the ‘marker’
     13        element or any of its ancestors is set to none."
     14
     15        Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
     16               svg/custom/painting-marker-07-f-inherit.svg
     17
     18        * svg/SVGMarkerElement.h:
     19        (WebCore::SVGMarkerElement::rendererIsNeeded):
     20
    1212011-05-18  Alexis Menard  <alexis.menard@openbossa.org>, Simon Hausmann  <simon.hausmann@nokia.com>
    222

  • trunk/Source/WebCore/svg/SVGMarkerElement.h

    r86765 r86791  
    7373
    7474    virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
     75    virtual bool rendererIsNeeded(RenderStyle*) { return true; }
    7576
    7677    virtual bool selfHasRelativeLengths() const;
Note: See TracChangeset for help on using the changeset viewer.