Changeset 86809 in webkit

Timestamp:

May 18, 2011 5:45:27 PM (13 years ago)

Author:

oliver@apple.com

Message:

2011-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
​https://bugs.webkit.org/show_bug.cgi?id=61064

Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
for its inline storage. This resolves the problem of GC occurring before
a subclass has initialised its anonymous storage.

• runtime/JSObject.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSObject.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-05-18  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
+        https://bugs.webkit.org/show_bug.cgi?id=61064
+
+        Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
+        for its inline storage.  This resolves the problem of GC occurring before
+        a subclass has initialised its anonymous storage.
+
+        * runtime/JSObject.h:
+
 2011-05-18  Adam Barth  <abarth@webkit.org>
 

trunk/Source/JavaScriptCore/runtime/JSObject.h

@@ -344 +344 @@
 
     private:
-        WriteBarrierBase<Unknown> m_inlineStorage[JSNonFinalObject_inlineStorageCapacity];
+        WriteBarrier<Unknown> m_inlineStorage[JSNonFinalObject_inlineStorageCapacity];
     };