Changeset 86828 in webkit


Ignore:
Timestamp:
May 19, 2011 2:22:47 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-19 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=61023

Added a test which ensures the IME candidate position is located
at suitable position.

  • platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
  • platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
  • platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.

2011-05-19 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=61023

Always adjusts the range to window relative coordinates.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition which excludes editable selectionRoot from adjusting.

2011-05-19 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=61023

Call the focused frame's firstRectForCharacterRange() instead of the
main frame so that DRT behaves as the same as Chromium.

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange):
Location:
trunk
Files:
5 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86827 r86828  
     12011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [Chromium] IME candidate window appears wrong position in an iframe
     6        https://bugs.webkit.org/show_bug.cgi?id=61023
     7
     8        Added a test which ensures the IME candidate position is located
     9        at suitable position.
     10
     11        * platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
     12        * platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
     13        * platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.
     14
    1152011-05-19  Emil A Eklund  <eae@chromium.org>
    216

  • trunk/Source/WebKit/chromium/ChangeLog

    r86816 r86828  
     12011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [Chromium] IME candidate window appears wrong position in an iframe
     6        https://bugs.webkit.org/show_bug.cgi?id=61023
     7
     8        Always adjusts the range to window relative coordinates.
     9
     10        * src/WebFrameImpl.cpp:
     11        (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition
     12        which excludes editable selectionRoot from adjusting.
     13
    1142011-05-18  Nat Duca  <nduca@chromium.org>
    215

  • trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

    r86813 r86828  
    11621162    IntRect intRect = frame()->editor()->firstRectForRange(range.get());
    11631163    rect = WebRect(intRect);
    1164     // When inside an text control, don't adjust the range.
    1165     if (!selectionRoot)
    1166         rect = frame()->view()->contentsToWindow(rect);
     1164    rect = frame()->view()->contentsToWindow(rect);
    11671165
    11681166    return true;

  • trunk/Tools/ChangeLog

    r86766 r86828  
     12011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [Chromium] IME candidate window appears wrong position in an iframe
     6        https://bugs.webkit.org/show_bug.cgi?id=61023
     7
     8        Call the focused frame's firstRectForCharacterRange() instead of the
     9        main frame so that DRT behaves as the same as Chromium.
     10
     11        * DumpRenderTree/chromium/TextInputController.cpp:
     12        (TextInputController::firstRectForCharacterRange):
     13
    1142011-05-18  Adam Roben  <aroben@apple.com>
    215

  • trunk/Tools/DumpRenderTree/chromium/TextInputController.cpp

    r75000 r86828  
    182182    result->setNull();
    183183
    184     WebFrame* mainFrame = getMainFrame();
    185     if (!mainFrame)
     184    WebFrame* frame = testShell->webView()->focusedFrame();
     185    if (!frame)
    186186        return;
    187187
    … …  
    190190
    191191    WebRect rect;
    192     if (!mainFrame->firstRectForCharacterRange(arguments[0].toInt32(), arguments[1].toInt32(), rect))
     192    if (!frame->firstRectForCharacterRange(arguments[0].toInt32(), arguments[1].toInt32(), rect))
    193193        return;
    194194
Note: See TracChangeset for help on using the changeset viewer.