Changeset 86926 in webkit

Timestamp:

May 19, 2011 11:37:01 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-19 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
​https://bugs.webkit.org/show_bug.cgi?id=61163

Manual test input-number-localization.html.
Because we can't assume any number formats in various WebKit ports.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
• manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLInputElement.cpp (modified) (1 diff)
• manual-tests/input-number-localization.html (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-19  Naoki Takano  <takano.naoki@gmail.com>
+
+        Reviewed by Kent Tamura.
+
+        Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
+        https://bugs.webkit.org/show_bug.cgi?id=61163
+
+        Manual test input-number-localization.html.
+        Because we can't assume any number formats in various WebKit ports.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
+        * manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.
+
 2011-05-19  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -944 +944 @@
 
     if (isTextField()) {
-        unsigned max = m_value.length();
+        unsigned max = visibleValue().length();
         if (document()->focusedNode() == this)
             WebCore::setSelectionRange(this, max, max);

trunk/Source/WebCore/manual-tests/input-number-localization.html

@@ -22 +22 @@
 <div>Standard format: <output id=output></output></div>
 
+<p>Input test: Type the number text "1234" into the the followin number field.
+The number string will be "1,234" and the cursor position must be the last position.
+</p>
+<div><input type="number" onkeyup="this.value=this.value" /></div>
+
 <script>
 function handleInput() {