Changeset 86948 in webkit

Timestamp:

May 20, 2011 6:49:54 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-20 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: console.log(XMLDocument) should be case preserving
​https://bugs.webkit.org/show_bug.cgi?id=60765

Changes the XML document checking from base documents MIME type
to xmlVersion parameter.

• inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
• inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorDOMAgent.cpp (modified) (1 diff)
• inspector/front-end/DOMAgent.js (modified) (1 diff)
• inspector/front-end/ElementsTreeOutline.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-20  Tonis Tiigi  <tonistiigi@gmail.com>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: console.log(XMLDocument) should be case preserving
+        https://bugs.webkit.org/show_bug.cgi?id=60765
+
+        Changes the XML document checking from base documents MIME type
+        to xmlVersion parameter.
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::buildObjectForNode):
+        * inspector/front-end/DOMAgent.js:
+        (WebInspector.DOMNode):
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
+
 2011-05-20  Mikhail Naganov  <mnaganov@chromium.org>
 

trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp

@@ -1095 +1095 @@
             Document* document = static_cast<Document*>(node);
             value->setString("documentURL", documentURLString(document));
+            value->setString("xmlVersion", document->xmlVersion());
         }
     } else if (node->nodeType() == Node::DOCUMENT_TYPE_NODE) {

trunk/Source/WebCore/inspector/front-end/DOMAgent.js

@@ -76 +76 @@
     } else if (this._nodeType === Node.DOCUMENT_NODE) {
         this.documentURL = payload.documentURL;
+        this.xmlVersion = payload.xmlVersion;
     } else if (this._nodeType === Node.ATTRIBUTE_NODE) {
         this.name = payload.name;

trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -57 +57 @@
         this._rootDOMNode = x;
 
-        this._isXMLMimeType = !!(WebInspector.mainResource && WebInspector.mainResource.mimeType && WebInspector.mainResource.mimeType.match(/x(?:ht)?ml/i));
+        this._isXMLMimeType = x && !!x.xmlVersion;
 
         this.update();