Changeset 86963 in webkit

Timestamp:

May 20, 2011 9:25:31 AM (13 years ago)

Author:

podivilov@chromium.org

Message:

2011-05-20 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=61133

• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DebuggerPresentationModel.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-20  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: breakpoints disappear from ui after navigation.
+        https://bugs.webkit.org/show_bug.cgi?id=61133
+
+        * inspector/front-end/DebuggerPresentationModel.js:
+        (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
+        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
+
 2011-05-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

@@ -68 +68 @@
     _debuggerWasEnabled: function()
     {
+        if (this._breakpointsRestored)
+            return;
         this._restoreBreakpointsFromSettings();
+        this._breakpointsRestored = true;
     },
 
@@ -508 +511 @@
 
         // Sanitize debugger ids.
-        for (var i = 0; i < serializedBreakpoints.length; ++i)
-            delete serializedBreakpoints[i].debuggerId;
+        for (var i = 0; i < serializedBreakpoints.length; ++i) {
+            var breakpoint = serializedBreakpoints[i];
+            var breakpointCopy = {};
+            for (var property in breakpoint) {
+                if (property !== "debuggerId")
+                    breakpointCopy[property] = breakpoint[property];
+            }
+            serializedBreakpoints[i] = breakpointCopy;
+        }
 
         WebInspector.settings.breakpoints = serializedBreakpoints;