Changeset 86978 in webkit

Timestamp:

May 20, 2011 12:53:13 PM (13 years ago)

Author:

rwlbuis@webkit.org

Message:

2011-05-20 Rob Buis <​rbuis@rim.com>

Reviewed by Dirk Schulze.

Use test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60844

When an id changes on an in-document element, we need to check whether the id
is part of the pending elements. Since this is the same thing as happens in
insertedIntoDocument, split out the common code into buildPendingResourcesIfNeeded.

Test: svg/W3C-SVG-1.1-SE/struct-use-14-f.svg

• svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
• svg/SVGStyledElement.h:

2011-05-20 Rob Buis <​rbuis@rim.com>

Reviewed by Dirk Schulze.

Use test from ietestcenter fails
​https://bugs.webkit.org/show_bug.cgi?id=60844

• platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
• svg/W3C-SVG-1.1-SE/struct-use-14-f.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/struct-use-14-f.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGStyledElement.cpp (modified) (2 diffs)
• Source/WebCore/svg/SVGStyledElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-20  Rob Buis  <rbuis@rim.com>
+
+        Reviewed by Dirk Schulze.
+
+        Use test from ietestcenter fails
+        https://bugs.webkit.org/show_bug.cgi?id=60844
+
+        * platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
+        * svg/W3C-SVG-1.1-SE/struct-use-14-f.svg: Added.
+
 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-20  Rob Buis  <rbuis@rim.com>
+
+        Reviewed by Dirk Schulze.
+
+        Use test from ietestcenter fails
+        https://bugs.webkit.org/show_bug.cgi?id=60844
+
+        When an id changes on an in-document element, we need to check whether the id
+        is part of the pending elements. Since this is the same thing as happens in
+        insertedIntoDocument, split out the common code into buildPendingResourcesIfNeeded.
+
+        Test: svg/W3C-SVG-1.1-SE/struct-use-14-f.svg
+
+        * svg/SVGStyledElement.cpp:
+        (WebCore::SVGStyledElement::svgAttributeChanged):
+        (WebCore::SVGStyledElement::insertedIntoDocument):
+        (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
+        * svg/SVGStyledElement.h:
+
 2011-05-20  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/svg/SVGStyledElement.cpp

@@ -337 +337 @@
         if (object && object->isSVGResourceContainer())
             object->toRenderSVGResourceContainer()->idChanged();
+        if (inDocument())
+            buildPendingResourcesIfNeeded();
     }
 
@@ -363 +365 @@
     SVGElement::insertedIntoDocument();
     updateRelativeLengthsInformation();
-
+    buildPendingResourcesIfNeeded();
+}
+
+void SVGStyledElement::buildPendingResourcesIfNeeded() const
+{
     Document* document = this->document();
     if (!needsPendingResourceHandling() || !document)

trunk/Source/WebCore/svg/SVGStyledElement.h

@@ -88 +88 @@
     virtual bool isStyled() const { return true; }
 
+    void buildPendingResourcesIfNeeded() const;
+
     HashSet<SVGStyledElement*> m_elementsWithRelativeLengths;