Changeset 87028 in webkit
- Timestamp:
- May 22, 2011 3:13:54 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r87027 r87028 1 2011-05-22 Dirk Schulze <krit@webkit.org> 2 3 Reviewed by Nikolas Zimmermann. 4 5 Don't do manually style resolution for SVGElements with renderer 6 https://bugs.webkit.org/show_bug.cgi?id=59176 7 8 General clean-up. 9 10 Don't resolve style manually, instead ask the RenderObject for its style. 11 12 Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes. 13 14 No new tests needed. No change of behavior. 15 16 * svg/SVGFEDiffuseLightingElement.cpp: 17 (WebCore::SVGFEDiffuseLightingElement::build): 18 * svg/SVGFEDropShadowElement.cpp: 19 (WebCore::SVGFEDropShadowElement::build): 20 * svg/SVGFEFloodElement.cpp: 21 (WebCore::SVGFEFloodElement::build): 22 * svg/SVGFESpecularLightingElement.cpp: 23 (WebCore::SVGFESpecularLightingElement::build): 24 * svg/svgattrs.in: 25 1 26 2011-05-21 Dirk Schulze <krit@webkit.org> 2 27 -
trunk/Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp
r87010 r87028 267 267 return 0; 268 268 269 RefPtr<RenderStyle> filterStyle = styleForRenderer(); 270 Color color = filterStyle->svgStyle()->lightingColor(); 269 RenderObject* renderer = this->renderer(); 270 if (!renderer) 271 return 0; 272 273 ASSERT(renderer->style()); 274 Color color = renderer->style()->svgStyle()->lightingColor(); 271 275 272 276 RefPtr<FilterEffect> effect = FEDiffuseLighting::create(filter, color, surfaceScale(), diffuseConstant(), -
trunk/Source/WebCore/svg/SVGFEDropShadowElement.cpp
r87010 r87028 189 189 190 190 ASSERT(renderer->style()); 191 ASSERT(renderer->style()->svgStyle());192 191 const SVGRenderStyle* svgStyle = renderer->style()->svgStyle(); 193 192 -
trunk/Source/WebCore/svg/SVGFEFloodElement.cpp
r86050 r87028 62 62 PassRefPtr<FilterEffect> SVGFEFloodElement::build(SVGFilterBuilder*, Filter* filter) 63 63 { 64 RefPtr<RenderStyle> filterStyle = styleForRenderer(); 64 RenderObject* renderer = this->renderer(); 65 if (!renderer) 66 return 0; 67 68 ASSERT(renderer->style()); 69 const SVGRenderStyle* svgStyle = renderer->style()->svgStyle(); 65 70 66 Color color = filterStyle->svgStyle()->floodColor();67 float opacity = filterStyle->svgStyle()->floodOpacity();71 Color color = svgStyle->floodColor(); 72 float opacity = svgStyle->floodOpacity(); 68 73 69 74 return FEFlood::create(filter, color, opacity); -
trunk/Source/WebCore/svg/SVGFESpecularLightingElement.cpp
r87010 r87028 281 281 return 0; 282 282 283 RefPtr<RenderStyle> filterStyle = styleForRenderer(); 284 285 Color color = filterStyle->svgStyle()->lightingColor(); 283 RenderObject* renderer = this->renderer(); 284 if (!renderer) 285 return 0; 286 287 ASSERT(renderer->style()); 288 Color color = renderer->style()->svgStyle()->lightingColor(); 286 289 287 290 RefPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, surfaceScale(), specularConstant(), -
trunk/Source/WebCore/svg/svgattrs.in
r71508 r87028 55 55 exponent 56 56 externalResourcesRequired 57 feColorMatrix58 feComposite59 feGaussianBlur60 feMorphology61 feTile62 57 fill 63 58 fill-opacity
Note: See TracChangeset
for help on using the changeset viewer.