Changeset 87106 in webkit

Timestamp:

May 23, 2011 4:50:21 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-23 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

fix rel=prerender target types
​https://bugs.webkit.org/show_bug.cgi?id=61297

The original fix in ​https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.

No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.

• loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):

2011-05-23 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

fix rel=prerender target types
​https://bugs.webkit.org/show_bug.cgi?id=61297

The original fix in ​https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.

No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.

• public/WebURLRequest.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/cache/CachedResourceRequest.cpp (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebURLRequest.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-23  Gavin Peters  <gavinp@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        fix rel=prerender target types
+        https://bugs.webkit.org/show_bug.cgi?id=61297
+
+        The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
+        didn't properly map the target type, and didn't carry the target
+        types through to chromium properly.  Fixed.
+
+        No new tests; it's very hard to catch these with a layout test, however
+        all of the chromium Prerender browser tests will test this functionality
+        when I land an upcoming chromium CL.
+
+        * loader/cache/CachedResourceRequest.cpp:
+        (WebCore::cachedResourceTypeToTargetType):
+
 2011-05-23  Matthew Delaney  <mdelaney@apple.com>
 

trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp

@@ -64 +64 @@
         return ResourceRequest::TargetIsPrefetch;
     case CachedResource::LinkPrerender:
-        return ResourceRequest::TargetIsSubresource;
+        return ResourceRequest::TargetIsPrerender;
     case CachedResource::LinkSubresource:
         return ResourceRequest::TargetIsSubresource;

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-05-23  Gavin Peters  <gavinp@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        fix rel=prerender target types
+        https://bugs.webkit.org/show_bug.cgi?id=61297
+
+        The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
+        didn't properly map the target type, and didn't carry the target
+        types through to chromium properly.  Fixed.
+
+        No new tests; it's very hard to catch these with a layout test, however
+        all of the chromium Prerender browser tests will test this functionality
+        when I land an upcoming chromium CL.
+
+        * public/WebURLRequest.h:
+
 2011-05-23  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebURLRequest.h

@@ -70 +70 @@
         TargetIsSharedWorker = 10,
         TargetIsPrefetch = 11,
-        TargetIsFavicon = 12,
+        TargetIsPrerender = 12,
+        TargetIsFavicon = 13,
     };