Changeset 87114 in webkit
- Timestamp:
- May 23, 2011 6:17:11 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r87111 r87114 1 2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org> 2 3 Reviewed by Darin Adler. 4 5 Test for: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem() 6 https://bugs.webkit.org/show_bug.cgi?id=57140 7 <rdar://problem/9191214> 8 9 * fast/storage/storage-detached-iframe-expected.txt: Added. 10 * fast/storage/storage-detached-iframe.html: Added. 11 12 * platform/chromium/test_expectations.txt: Marked the test as CRASH 13 on Chromium - Linux. 14 1 15 2011-05-23 Chris Fleizach <cfleizach@apple.com> 2 16 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r87067 r87114 4168 4168 // New test from WK r87026 4169 4169 BUGCR83555 WIN LINUX : fast/block/positioning/058.html = IMAGE+TEXT 4170 4171 BUGWK61326 LINUX : fast/storage/storage-detached-iframe.html = PASS CRASH -
trunk/Source/WebCore/ChangeLog
r87111 r87114 1 2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org> 2 3 Reviewed by Darin Adler. 4 5 Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem() 6 https://bugs.webkit.org/show_bug.cgi?id=57140 7 8 Test: fast/storage/storage-detached-iframe.html 9 10 Access of localStorage on a detached iframe was causing a crash because a detached 11 iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such. 12 13 * storage/StorageAreaImpl.cpp: 14 (WebCore::privateBrowsingEnabled): check that child->page() is non-null before 15 accessing it. 16 1 17 2011-05-23 Chris Fleizach <cfleizach@apple.com> 2 18 -
trunk/Source/WebCore/storage/StorageAreaImpl.cpp
r85395 r87114 104 104 return false; 105 105 #else 106 return frame->page() ->settings()->privateBrowsingEnabled();106 return frame->page() && frame->page()->settings()->privateBrowsingEnabled(); 107 107 #endif 108 108 }
Note: See TracChangeset
for help on using the changeset viewer.