Changeset 87124 in webkit

Timestamp:

May 23, 2011 8:41:06 PM (13 years ago)

Author:

tony@chromium.org

Message:

2011-05-23 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[nrwt] don't use NetworkTranslation when uploading results
​https://bugs.webkit.org/show_bug.cgi?id=61315

This avoids autoinstalling mechanize. It didn't matter anyway
because test_results_uploader.py wasn't using mechanize to make the
request so NetworkTransaction::run wasn't doing anything extra
(it only matters if it catches mechanize.HTTPError).

• Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-23  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        [nrwt] don't use NetworkTranslation when uploading results
+        https://bugs.webkit.org/show_bug.cgi?id=61315
+
+        This avoids autoinstalling mechanize.  It didn't matter anyway
+        because test_results_uploader.py wasn't using mechanize to make the
+        request so NetworkTransaction::run wasn't doing anything extra
+        (it only matters if it catches mechanize.HTTPError).
+
+        * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
+
 2011-05-23  Tony Chang  <tony@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py

@@ -34 +34 @@
 import socket
 import urllib2
-
-from webkitpy.common.net.networktransaction import NetworkTransaction
 
 def get_mime_type(filename):
@@ -102 +100 @@
         try:
             socket.setdefaulttimeout(timeout_seconds)
-            NetworkTransaction(timeout_seconds=timeout_seconds).run(
-                lambda: self._upload_files(params, file_objs))
+            self._upload_files(params, file_objs)
         finally:
             socket.setdefaulttimeout(orig_timeout)