Changeset 87204 in webkit

Timestamp:

May 24, 2011 2:22:27 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

2011-05-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Undo gets broken in contenteditable area when a text field's value is set by script
​https://bugs.webkit.org/show_bug.cgi?id=61340

Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.

• editing/undo/undo-after-setting-value-expected.txt: Added.
• editing/undo/undo-after-setting-value.html: Added.

2011-05-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Undo gets broken in contenteditable area when a text field's value is set by script
​https://bugs.webkit.org/show_bug.cgi?id=61340

The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
calling clearUndoRedoOperations whenever script sets new value to input or textarea.

Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.

Test: editing/undo/undo-after-setting-value.html

• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/undo/undo-after-setting-value-expected.txt (added)
• LayoutTests/editing/undo/undo-after-setting-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTextControl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Undo gets broken in contenteditable area when a text field's value is set by script
+        https://bugs.webkit.org/show_bug.cgi?id=61340
+
+        Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.
+
+        * editing/undo/undo-after-setting-value-expected.txt: Added.
+        * editing/undo/undo-after-setting-value.html: Added.
+
 2011-05-24  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Undo gets broken in contenteditable area when a text field's value is set by script
+        https://bugs.webkit.org/show_bug.cgi?id=61340
+
+        The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
+        calling clearUndoRedoOperations whenever script sets new value to input or textarea.
+
+        Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
+        was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
+        and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.
+
+        Test: editing/undo/undo-after-setting-value.html
+
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::setInnerTextValue):
+
 2011-05-24  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/rendering/RenderTextControl.cpp

@@ -148 +148 @@
     String value = innerTextValue;
     if (value != text() || !innerTextElement()->hasChildNodes()) {
-        if (value != text()) {
-            if (Frame* frame = this->frame()) {
-                frame->editor()->clearUndoRedoOperations();
-                
-                if (AXObjectCache::accessibilityEnabled())
-                    document()->axObjectCache()->postNotification(this, AXObjectCache::AXValueChanged, false);
-            }
-        }
+        if (value != text() && document() && AXObjectCache::accessibilityEnabled())
+            document()->axObjectCache()->postNotification(this, AXObjectCache::AXValueChanged, false);
 
         ExceptionCode ec = 0;