Changeset 87268 in webkit

Timestamp:

May 24, 2011 9:35:37 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-24 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Move chromium media controls timeline back to flexible rather than absolute
layout.

​https://bugs.webkit.org/show_bug.cgi?id=61379

• platform/chromium/test_expectations.txt: Added expected failures from this change.

2011-05-24 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Move chromium media controls timeline back to flexible rather than absolute
layout.

​https://bugs.webkit.org/show_bug.cgi?id=61379

• css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/mediaControlsChromium.css (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-24  Steve Lacey  <sjl@chromium.org>
+
+        Reviewed by Eric Carlson.
+
+        Move chromium media controls timeline back to flexible rather than absolute
+        layout.
+
+        https://bugs.webkit.org/show_bug.cgi?id=61379
+
+        * platform/chromium/test_expectations.txt: Added expected failures from this change.
+
 2011-05-24  Kent Tamura  <tkent@chromium.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -2940 +2940 @@
 
 // 2 pixel stretching when rendering some videos with the GPU (Now it's flaky)
-BUGCR74102 GPU LINUX : media/video-controls-rendering.html = IMAGE PASS
+// Revert back to commented line once WK61380 is checked in.
+//BUGCR74102 GPU LINUX : media/video-controls-rendering.html = IMAGE PASS
+BUGCR74102 GPU LINUX : media/video-controls-rendering.html = IMAGE+TEXT TEXT
+
 // BUGCR74102 GPU WIN : media/video-layer-crash.html = IMAGE
 
@@ -3649 +3652 @@
 BUGWK60103 WIN LINUX : fast/replaced/border-radius-clip.html = IMAGE
 
-// Regressed in r85290 but should start passing when underlying flexbox bugs are fixed.
-BUGCR59704 BUGWK59644 : media/video-zoom-controls.html = IMAGE+TEXT
+// Temporarily failing TEXT due to media controls using flexbox again.
+BUGWK61380 : fast/layers/video-layer.html = TEXT
+BUGWK61380 : media/controls-without-preload.html = TEXT
+BUGWK61380 : media/audio-controls-rendering.html = TEXT
+BUGWK61380 : media/audio-repaint.html = TEXT
+BUGWK61380 : media/controls-after-reload.html = TEXT
+BUGWK61380 : media/controls-strict.html = TEXT
+BUGWK61380 : media/controls-styling.html = TEXT
+BUGWK61380 CPU : media/video-controls-rendering.html = TEXT
+BUGWK61380 GPU WIN MAC : media/video-controls-rendering.html = TEXT
+BUGWK61380 : media/video-display-toggle.html = TEXT
+BUGWK61380 : media/video-empty-source.html = TEXT
+BUGWK61380 : media/video-no-audio.html = TEXT
+BUGWK61380 : media/video-volume-slider.html = TEXT
 
 // probably just needs a new baseline

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-24  Steve Lacey  <sjl@chromium.org>
+
+        Reviewed by Eric Carlson.
+
+        Move chromium media controls timeline back to flexible rather than absolute
+        layout.
+
+        https://bugs.webkit.org/show_bug.cgi?id=61379
+
+        * css/mediaControlsChromium.css:
+        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
+        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
+
 2011-05-24  Fumitoshi Ukai  <ukai@chromium.org>
 

trunk/Source/WebCore/css/mediaControlsChromium.css

@@ -103 +103 @@
     cursor: default;
 
-    position: absolute;
-    top: 6px;
-    right: 0;
-
     line-height: 21px;
     height: 20px;
@@ -131 +127 @@
     -webkit-box-flex: 1;
 
-    position: absolute;
-    top: 7px;
-    left: 6px;
-    right: 64px;
-
     padding: 0px;
-    margin: 0px;
+    margin: 0px 6px;
     height: 18px;