Changeset 87278 in webkit

Timestamp:

May 25, 2011 12:45:33 AM (13 years ago)

Author:

yurys@chromium.org

Message:

2011-05-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
​https://bugs.webkit.org/show_bug.cgi?id=61194

Test: inspector/console/console-eval-syntax-error.html

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error

2011-05-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
​https://bugs.webkit.org/show_bug.cgi?id=61194

• inspector/console/console-eval-syntax-error-expected.txt: Added.
• inspector/console/console-eval-syntax-error.html: Added.
• platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/console/console-eval-syntax-error-expected.txt (added)
• LayoutTests/inspector/console/console-eval-syntax-error.html (added)
• LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-23  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
+        https://bugs.webkit.org/show_bug.cgi?id=61194
+
+        * inspector/console/console-eval-syntax-error-expected.txt: Added.
+        * inspector/console/console-eval-syntax-error.html: Added.
+        * platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.
+
 2011-05-24  Keishi Hattori  <keishi@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-23  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
+        https://bugs.webkit.org/show_bug.cgi?id=61194
+
+        Test: inspector/console/console-eval-syntax-error.html
+
+        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+        (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
+
 2011-05-25  Yuzo Fujishima  <yuzo@google.com>
 

trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -77 +77 @@
 
     v8::Handle<v8::Script> script = v8::Script::Compile(expression);
+    if (script.IsEmpty()) // Return immediately in case of exception to let the caller handle it.
+        return v8::Handle<v8::Value>();
     return script->Run();
 }