Changeset 87306 in webkit


Ignore:
Timestamp:
May 25, 2011 10:58:48 AM (13 years ago)
Author:
robert@webkit.org
Message:

2011-05-20 Robert Hogan <robert@webkit.org>

Reviewed by Geoffrey Garen.

[Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html

Use the test netscape plugin instead of quicktime.
Allows the test to pass on Qt/Gtk/Chromium as well as Mac.

https://bugs.webkit.org/show_bug.cgi?id=61182
http://code.google.com/p/chromium/issues/detail?id=15797

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • plugins/embed-attributes-setting-expected.txt:
  • plugins/embed-attributes-setting.html:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r87300 r87306  
     12011-05-20  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Geoffrey Garen.
     4
     5        [Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html
     6
     7        Use the test netscape plugin instead of quicktime.
     8        Allows the test to pass on Qt/Gtk/Chromium as well as Mac.
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=61182
     11        http://code.google.com/p/chromium/issues/detail?id=15797
     12
     13        * platform/chromium/test_expectations.txt:
     14        * platform/gtk/Skipped:
     15        * platform/qt/Skipped:
     16        * plugins/embed-attributes-setting-expected.txt:
     17        * plugins/embed-attributes-setting.html:
     18
    1192011-05-25  Leon Scroggins  <scroggo@google.com>
    220
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r87300 r87306  
    11421142// overlap, but it's very close and quite different from the Windows version
    11431143BUGCR10350 LINUX : fast/replaced/width100percent-radio.html = FAIL
    1144 
    1145 // These tests are marked as failing on Linux because they depend on QuickTime.
    1146 // See the bug for more discussion.
    1147 BUGCR15797 LINUX : plugins/embed-attributes-setting.html = FAIL CRASH
    11481144
    11491145// Skip because we throw an exception before we get to dumpAsText.
  • trunk/LayoutTests/platform/gtk/Skipped

    r87296 r87306  
    581581# Tests in plugins/ directory
    582582#   Tests failing, need to implement NPP_HandleEvent() in TestNetscapePlugin
    583 plugins/embed-attributes-setting.html
    584583plugins/get-url-with-blank-target.html
    585584plugins/plugin-initiate-popup-window.html
  • trunk/LayoutTests/platform/qt/Skipped

    r87274 r87306  
    355355# ---- plugins rendered in incorrect position ?
    356356plugins/embed-attributes-style.html
    357 
    358 # https://bugs.webkit.org/show_bug.cgi?id=61182
    359 plugins/embed-attributes-setting.html
    360357
    361358# https://bugs.webkit.org/show_bug.cgi?id=41292
  • trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt

    r30635 r87306  
    66PASS: embed.getAttribute('type') should be 1 and is.
    77PASS: embed.getAttribute('src') should be 1 and is.
    8 PASS: typeof embed.Play should be function and is.
     8PASS: typeof embed.testCallback should be function and is.
    99----------
    1010[Embed is dynamically created element with only type specified]
    11 PASS: typeof embed.Play should be function and is.
     11PASS: typeof embed.testCallback should be function and is.
    1212----------
    1313[Embed is dynamically created element with only src specified]
    14 PASS: typeof embed.Play should be function and is.
     14PASS: typeof embed.testCallback should be function and is.
    1515 
  • trunk/LayoutTests/plugins/embed-attributes-setting.html

    r14069 r87306  
    4949    shouldBe("embed.getAttribute('type')", 1);
    5050    shouldBe("embed.getAttribute('src')", 1);
    51     shouldBe("typeof embed.Play", "function");
     51    shouldBe("typeof embed.testCallback", "function");
    5252
    5353    print("----------");
     
    5757
    5858    embed.style.visibility = "hidden";
    59     embed.type = "video/quicktime";
     59    embed.type = "application/x-webkit-test-netscape";
    6060    document.body.appendChild(embed);
    61     shouldBe("typeof embed.Play", "function");
     61    shouldBe("typeof embed.testCallback", "function");
    6262   
    6363    print("----------");
     
    6767
    6868    embed.style.visibility = "hidden";
    69     embed.src = "resources/articles.m4a";
     69    embed.src = "resources/test.testnetscape";
    7070    document.body.appendChild(embed);
    71     shouldBe("typeof embed.Play", "function");
     71    shouldBe("typeof embed.testCallback", "function");
    7272}
    7373</script>
     
    7979<div id='console'></div>
    8080
    81 <embed style="visibility: hidden" type="video/quicktime" id='embed'></embed>
     81<embed style="visibility: hidden" type="application/x-webkit-test-netscape" id='embed'></embed>
    8282
    8383</body>
Note: See TracChangeset for help on using the changeset viewer.