Changeset 87310 in webkit

Timestamp:

May 25, 2011 12:01:46 PM (13 years ago)

Author:

rwlbuis@webkit.org

Message:

2011-05-25 Rob Buis <​rbuis@rim.com>

Reviewed by Eric Seidel.

WebKit does not handle missing filter elements correctly
​https://bugs.webkit.org/show_bug.cgi?id=12569

Updated improved pixel test result and add new SVG1.1 SE test and results.

• platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
• svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.

2011-05-25 Rob Buis <​rbuis@rim.com>

Reviewed by Eric Seidel.
New test rubber-stamped by Dirk Schulze.

WebKit does not handle missing filter elements correctly
​https://bugs.webkit.org/show_bug.cgi?id=12569

Do not render elements that reference non-existant filters.

Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg

• rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png (modified) (previous)
• LayoutTests/svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/SVGRenderSupport.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-25  Rob Buis  <rbuis@rim.com>
+
+        Reviewed by Eric Seidel.
+
+        WebKit does not handle missing filter elements correctly
+        https://bugs.webkit.org/show_bug.cgi?id=12569
+
+        Updated improved pixel test result and add new SVG1.1 SE test and results.
+
+        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+        * svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
+
 2011-05-25  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-25  Rob Buis  <rbuis@rim.com>
+
+        Reviewed by Eric Seidel.
+        New test rubber-stamped by Dirk Schulze.
+
+        WebKit does not handle missing filter elements correctly
+        https://bugs.webkit.org/show_bug.cgi?id=12569
+
+        Do not render elements that reference non-existant filters.
+
+        Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg
+
+        * rendering/svg/SVGRenderSupport.cpp:
+        (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
+
 2011-05-25  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp

@@ -107 +107 @@
 
     SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(object);
-    if (!resources)
+    if (!resources) {
+#if ENABLE(FILTERS)
+        if (svgStyle->hasFilter())
+            return false;
+#endif
         return true;
+    }
 
     if (RenderSVGResourceMasker* masker = resources->masker()) {