Changeset 87323 in webkit


Ignore:
Timestamp:
May 25, 2011 2:47:39 PM (13 years ago)
Author:
scherkus@chromium.org
Message:

2011-05-25 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix media element regression where ended event stopped firing after changing the src attribute.

https://bugs.webkit.org/show_bug.cgi?id=61336

  • media/media-ended-expected.txt: Added.
  • media/media-ended.html: Added.

2011-05-25 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix media element regression where ended event stopped firing after changing the src attribute.

https://bugs.webkit.org/show_bug.cgi?id=61336

Test: media/media-ended.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r87322 r87323  
     12011-05-25  Andrew Scherkus  <scherkus@chromium.org>
     2
     3        Reviewed by Eric Carlson.
     4
     5        Fix media element regression where ended event stopped firing after changing the src attribute.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=61336
     8
     9        * media/media-ended-expected.txt: Added.
     10        * media/media-ended.html: Added.
     11
    1122011-05-25  Jer Noble  <jer.noble@apple.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r87322 r87323  
     12011-05-25  Andrew Scherkus  <scherkus@chromium.org>
     2
     3        Reviewed by Eric Carlson.
     4
     5        Fix media element regression where ended event stopped firing after changing the src attribute.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=61336
     8
     9        Test: media/media-ended.html
     10
     11        * html/HTMLMediaElement.cpp:
     12        (WebCore::HTMLMediaElement::prepareForLoad):
     13
    1142011-05-25  Jer Noble  <jer.noble@apple.com>
    215
  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r87322 r87323  
    516516    stopPeriodicTimers();
    517517    m_loadTimer.stop();
     518    m_sentEndEvent = false;
    518519    m_sentStalledEvent = false;
    519520    m_haveFiredLoadedData = false;
Note: See TracChangeset for help on using the changeset viewer.