Changeset 87361 in webkit

Timestamp:

May 25, 2011 11:20:35 PM (13 years ago)

Author:

simonjam@chromium.org

Message:

2011-05-25 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

Add site-specific hack for zipcar.com with old versions of requirejs.
​https://bugs.webkit.org/show_bug.cgi?id=61321

Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
order. This used to work in webkit by setting a bogus script type (script/cache), then
changing the type to a valid one when they wanted to execute it. This hack translates the
behavior into the new API (by disabling forceAsync).

• html/HTMLScriptElement.cpp: (WebCore::needsOldRequirejsQuirk): Added. (WebCore::HTMLScriptElement::insertedIntoDocument): If hack is needed, set a proper script type so script loads. If script isn't async, disable forceAsync so script executes in order.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLScriptElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-25  James Simonsen  <simonjam@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Add site-specific hack for zipcar.com with old versions of requirejs.
+        https://bugs.webkit.org/show_bug.cgi?id=61321
+
+        Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
+        order. This used to work in webkit by setting a bogus script type (script/cache), then
+        changing the type to a valid one when they wanted to execute it. This hack translates the
+        behavior into the new API (by disabling forceAsync).
+
+        * html/HTMLScriptElement.cpp:
+        (WebCore::needsOldRequirejsQuirk): Added.
+        (WebCore::HTMLScriptElement::insertedIntoDocument):
+        If hack is needed, set a proper script type so script loads.
+        If script isn't async, disable forceAsync so script executes in order.
+
 2011-05-25  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/html/HTMLScriptElement.cpp

@@ -30 +30 @@
 #include "HTMLNames.h"
 #include "ScriptEventListener.h"
+#include "Settings.h"
 #include "Text.h"
 
@@ -82 +83 @@
 }
 
+static bool needsOldRequirejsQuirk(HTMLScriptElement* element)
+{
+    if (element->fastGetAttribute(typeAttr) != "script/cache")
+        return false;
+
+    Document* document = element->document();
+
+    const KURL& url = document->url();
+    if (!equalIgnoringCase(url.host(), "www.zipcar.com"))
+        return false;
+
+    Settings* settings = document->settings();
+    if (!settings)
+        return false;
+    if (!settings->needsSiteSpecificQuirks())
+        return false;
+
+    return true;
+}
+
 void HTMLScriptElement::insertedIntoDocument()
 {
+    if (needsOldRequirejsQuirk(this)) {
+        if (!asyncAttributeValue())
+            handleAsyncAttribute(); // Clear forceAsync, so this script loads in parallel, but executes in order.
+        setAttribute(typeAttr, "text/javascript");
+    }
     HTMLElement::insertedIntoDocument();
     ScriptElement::insertedIntoDocument();