Changeset 87366 in webkit

Timestamp:

May 26, 2011 12:15:36 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-26 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

drag-not-loaded-image.html test crashes when WebKit is built with debug option
​https://bugs.webkit.org/show_bug.cgi?id=61480

Checks if image has content before starting to drag.

• page/DragController.cpp: (WebCore::DragController::startDrag):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DragController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-26  Igor Oliveira  <igor.oliveira@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
+        drag-not-loaded-image.html test crashes when WebKit is built with debug option
+        https://bugs.webkit.org/show_bug.cgi?id=61480
+
+        Checks if image has content before starting to drag.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::startDrag):
+
 2011-05-26  Alok Priyadarshi  <alokp@chromium.org>
 

trunk/Source/WebCore/page/DragController.cpp

@@ -732 +732 @@
         }
         doSystemDrag(dragImage, dragLoc, dragOrigin, clipboard, src, false);
-    } else if (!imageURL.isEmpty() && node && node->isElementNode() && image
+    } else if (!imageURL.isEmpty() && node && node->isElementNode() && image && !image->isNull()
                && (m_dragSourceAction & DragSourceActionImage)) {
         // We shouldn't be starting a drag for an image that can't provide an extension.