Changeset 87380 in webkit

Timestamp:

May 26, 2011 6:20:00 AM (13 years ago)

Author:

Adam Roben

Message:

Don't assume that builds finish in the order they were started

Fixes <​http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
build when one slave is taking a long time to finish a build

Reviewed by Antti Koivisto.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
newer than the oldest in-progress build are also themselves in progress. Just check whether
each build is actually in progress (as signified by its presence in the currentBuilds set).

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js

@@ -69 +69 @@
             var data = JSON.parse(xhr.responseText);
 
-            var oldestUnfinishedBuild = Infinity;
+            var currentBuilds = {};
             if ('currentBuilds' in data)
-                oldestUnfinishedBuild = data.currentBuilds[0];
+                data.currentBuilds.forEach(function(buildNumber) { currentBuilds[buildNumber] = true });
 
             for (var i = data.cachedBuilds.length - 1; i >= 0; --i) {
-                if (data.cachedBuilds[i] >= oldestUnfinishedBuild)
+                if (data.cachedBuilds[i] in currentBuilds)
                     continue;
 

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-25  Adam Roben  <aroben@apple.com>
+
+        Don't assume that builds finish in the order they were started
+
+        Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
+        build when one slave is taking a long time to finish a build
+
+        Reviewed by Antti Koivisto.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
+        (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
+        newer than the oldest in-progress build are also themselves in progress. Just check whether
+        each build is actually in progress (as signified by its presence in the currentBuilds set).
+
 2011-05-25  Adam Roben  <aroben@apple.com>