Changeset 87388 in webkit

Timestamp:

May 26, 2011 8:54:54 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: In network panel, show transfer size in a first line of resource row.
​https://bugs.webkit.org/show_bug.cgi?id=61354

• English.lproj/localizedStrings.js:
• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/NetworkPanel.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-26  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: In network panel, show transfer size in a first line of resource row.
+        https://bugs.webkit.org/show_bug.cgi?id=61354
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype._createTable):
+        (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
+
 2011-05-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -176 +176 @@
         columns.type.width = "6%";
 
-        columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Transfer"));
+        columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Content"));
         columns.size.sortable = true;
         columns.size.width = "6%";
@@ -1601 +1601 @@
     _refreshSizeCell: function()
     {
-        var resourceSize = typeof this._resource.resourceSize === "number" ? Number.bytesToString(this._resource.resourceSize) : "?";
-        var transferSize = typeof this._resource.transferSize === "number" ? Number.bytesToString(this._resource.transferSize) : "?";
-        var fromCache = this._resource.cached;
-        this._sizeCell.setTextAndTitle(!fromCache ? resourceSize : WebInspector.UIString("(from cache)"));
-        if (fromCache)
+        if (this._resource.cached) {
+            this._sizeCell.setTextAndTitle(WebInspector.UIString("(from cache)"));
             this._sizeCell.addStyleClass("network-dim-cell");
-        else
+        } else {
+            var resourceSize = typeof this._resource.resourceSize === "number" ? Number.bytesToString(this._resource.resourceSize) : "?";
+            var transferSize = typeof this._resource.transferSize === "number" ? Number.bytesToString(this._resource.transferSize) : "?";
+            this._sizeCell.setTextAndTitle(transferSize);
             this._sizeCell.removeStyleClass("network-dim-cell");
-        if (!fromCache)
-            this._appendSubtitle(this._sizeCell, transferSize);
+            this._appendSubtitle(this._sizeCell, resourceSize);
+        }
     },