Changeset 87480 in webkit


Ignore:
Timestamp:
May 27, 2011 12:26:34 AM (13 years ago)
Author:
morrita@google.com
Message:

2011-05-26 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary crashes
​https://bugs.webkit.org/show_bug.cgi?id=61511

  • fast/html/details-summary-document-child-expected.txt: Added.
  • fast/html/details-summary-document-child.html: Added.

2011-05-26 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
​https://bugs.webkit.org/show_bug.cgi?id=61511

Removed Unnecessary wrong cast to Elmement, which can be non-Element.

Test: fast/html/details-summary-document-child.html

  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::detailsElement):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r87478 r87480  
     12011-05-26  MORITA Hajime <morrita@google.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        WebCore::HTMLSummaryElement::isMainSummary crashes
     6        https://bugs.webkit.org/show_bug.cgi?id=61511
     7
     8        * fast/html/details-summary-document-child-expected.txt: Added.
     9        * fast/html/details-summary-document-child.html: Added.
     10
    1112011-05-26  Ryosuke Niwa  <rniwa@webkit.org>
    212

  • trunk/Source/WebCore/ChangeLog

    r87479 r87480  
     12011-05-26  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
     6        https://bugs.webkit.org/show_bug.cgi?id=61511
     7
     8        Removed Unnecessary wrong cast to Elmement, which can be non-Element.
     9
     10        Test: fast/html/details-summary-document-child.html
     11
     12        * html/HTMLSummaryElement.cpp:
     13        (WebCore::HTMLSummaryElement::detailsElement):
     14
    1152011-05-26  Adam Barth  <abarth@webkit.org>
    216

  • trunk/Source/WebCore/html/HTMLSummaryElement.cpp

    r86726 r87480  
    8383HTMLDetailsElement* HTMLSummaryElement::detailsElement() const
    8484{
    85     Element* mayDetails = toElement(const_cast<HTMLSummaryElement*>(this)->parentNodeForRenderingAndStyle());
     85    Node* mayDetails = const_cast<HTMLSummaryElement*>(this)->parentNodeForRenderingAndStyle();
    8686    if (!mayDetails || !mayDetails->hasTagName(detailsTag))
    8787        return 0;
Note: See TracChangeset for help on using the changeset viewer.