Changeset 87617 in webkit

Timestamp:

May 28, 2011 10:55:16 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-28 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
​https://bugs.webkit.org/show_bug.cgi?id=60535

Adding cases that test invalid properties.

• inspector/styles/styles-computed-trace-expected.txt:
• inspector/styles/styles-computed-trace.html:

2011-05-28 Tonis Tiigi <​tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
​https://bugs.webkit.org/show_bug.cgi?id=60535

• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/styles/styles-computed-trace-expected.txt (modified) (2 diffs)
• LayoutTests/inspector/styles/styles-computed-trace.html (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/StylesSidebarPane.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: there is a problem with computed style properties with wrong values
+        https://bugs.webkit.org/show_bug.cgi?id=60535
+
+        Adding cases that test invalid properties.
+
+        * inspector/styles/styles-computed-trace-expected.txt:
+        * inspector/styles/styles-computed-trace.html:
+
 2011-05-28  Robert Hogan  <robert@webkit.org>
 

trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt

@@ -4 +4 @@
 [expanded]  ()
 background-attachment: scroll;
-    #id1 - initial styles-computed-trace.html:19
+    #id1 - initial styles-computed-trace.html:23
 background-clip: border-box;
-    #id1 - initial styles-computed-trace.html:19
+    #id1 - initial styles-computed-trace.html:23
 background-color: gray;
-    #id1 - gray styles-computed-trace.html:19
-    /-- overloaded --/ #id1 - black styles-computed-trace.html:14
-    /-- overloaded --/ #id1 - green styles-computed-trace.html:9
+    #id1 - gray styles-computed-trace.html:23
+    /-- overloaded --/ #id1 - black styles-computed-trace.html:18
+    /-- overloaded --/ #id1 - green styles-computed-trace.html:13
 background-image: none;
-    #id1 - initial styles-computed-trace.html:19
+    #id1 - initial styles-computed-trace.html:23
 background-origin: padding-box;
-    #id1 - initial styles-computed-trace.html:19
+    #id1 - initial styles-computed-trace.html:23
 display: block;
     div - block user agent stylesheet
 font-family: Courier;
-    #id1 - Courier styles-computed-trace.html:14
-    /-- overloaded --/ #id1 - Times styles-computed-trace.html:9
+    #id1 - Courier styles-computed-trace.html:18
+    /-- overloaded --/ #id1 - Times styles-computed-trace.html:13
     /-- overloaded --/ body - Arial styles-computed-trace.html:4
+text-decoration: underline;
+    div - underline styles-computed-trace.html:9
 
 [expanded] element.style { ()
@@ -28 +30 @@
 [expanded]  ()
 background-color: blue;
-    #id2 - blue styles-computed-trace.html:23
+    #id2 - blue styles-computed-trace.html:27
 display: block;
     div - block user agent stylesheet
 font-family: Courier;
-    #id2 - Courier styles-computed-trace.html:23
-    /-- overloaded --/ #id1 - Courier styles-computed-trace.html:14
-    /-- overloaded --/ #id1 - Times styles-computed-trace.html:9
+    #id2 - Courier styles-computed-trace.html:27
+    /-- overloaded --/ #id1 - Courier styles-computed-trace.html:18
+    /-- overloaded --/ #id1 - Times styles-computed-trace.html:13
     /-- overloaded --/ body - Arial styles-computed-trace.html:4
+text-decoration: underline;
+    /-- overloaded --/ #id2 - invalidvalue styles-computed-trace.html:27
+    div - underline styles-computed-trace.html:9
 
 [expanded] element.style { ()

trunk/LayoutTests/inspector/styles/styles-computed-trace.html

@@ -5 +5 @@
     background-color: rgb(100, 0, 0);
     font-family: Arial;
+}
+
+div {
+    text-decoration: underline;
 }
 
@@ -24 +28 @@
     background-color: blue;
     font-family: Courier;
+    text-decoration: invalidvalue;
 }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: there is a problem with computed style properties with wrong values
+        https://bugs.webkit.org/show_bug.cgi?id=60535
+
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
+        (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
+
 2011-05-26  Antonio Gomes  <agomes@rim.com>
 

trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js

@@ -397 +397 @@
             for (var j = 0; j < allProperties.length; ++j) {
                 var property = allProperties[j];
-                if (!property.isLive)
+                if (!property.isLive || !property.parsedOk)
                     continue;
                 var name = property.name;
@@ -1130 +1130 @@
                     if (section.isPropertyOverloaded(property.name))
                         childElement.listItemElement.addStyleClass("overloaded");
+                    if (!property.parsedOk)
+                        childElement.listItemElement.addStyleClass("not-parsed-ok");
                 }
             }