Changeset 87680 in webkit

Timestamp:

May 30, 2011 1:30:17 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-30 Ryan Sleevi <​rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
​https://bugs.webkit.org/show_bug.cgi?id=61603

• platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
• platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
• svg/filters/feConvolveFilter-y-bounds.svg: Added.

2011-05-30 Ryan Sleevi <​rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
​https://bugs.webkit.org/show_bug.cgi?id=61603

Test: svg/filters/feConvolveFilter-y-bounds.svg

• platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::getPixelValue):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png (added)
• LayoutTests/platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt (added)
• LayoutTests/svg/filters/feConvolveFilter-y-bounds.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
+        https://bugs.webkit.org/show_bug.cgi?id=61603
+
+        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
+        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
+        * svg/filters/feConvolveFilter-y-bounds.svg: Added.
+
 2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
+        https://bugs.webkit.org/show_bug.cgi?id=61603
+
+        Test: svg/filters/feConvolveFilter-y-bounds.svg
+
+        * platform/graphics/filters/FEConvolveMatrix.cpp:
+        (WebCore::FEConvolveMatrix::getPixelValue):
+
 2011-05-30  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp

@@ -291 +291 @@
 ALWAYS_INLINE int FEConvolveMatrix::getPixelValue(PaintingData& paintingData, int x, int y)
 {
-    if (x >= 0 && x < paintingData.width && x >= 0 && y < paintingData.height)
+    if (x >= 0 && x < paintingData.width && y >= 0 && y < paintingData.height)
         return (y * paintingData.width + x) << 2;