Changeset 87752 in webkit


Ignore:
Timestamp:
May 31, 2011 2:50:19 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-31 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
https://bugs.webkit.org/show_bug.cgi?id=61593

Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
This is extremely defensive and not strictly necessary, but not harmful either.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::~CCLayerImpl):
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r87750 r87752  
     12011-05-31  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
     6        https://bugs.webkit.org/show_bug.cgi?id=61593
     7
     8        Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
     9        This is extremely defensive and not strictly necessary, but not harmful either.
     10
     11        * platform/graphics/chromium/LayerChromium.h:
     12        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
     13        (WebCore::CCLayerImpl::~CCLayerImpl):
     14
    1152011-05-31  Stephen White  <senorblanco@chromium.org>
    216
  • trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h

    r86652 r87752  
    216216
    217217    friend class TreeSynchronizer;
     218    friend class CCLayerImpl;
    218219    // Constructs a CCLayerImpl of the correct runtime type for this LayerChromium type.
    219220    virtual PassRefPtr<CCLayerImpl> createCCLayerImpl();
  • trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp

    r86975 r87752  
    8282CCLayerImpl::~CCLayerImpl()
    8383{
     84    if (m_owner)
     85        m_owner->setCCLayerImpl(0);
    8486}
    8587
Note: See TracChangeset for help on using the changeset viewer.