Changeset 87773 in webkit


Ignore:
Timestamp:
May 31, 2011 10:46:37 PM (13 years ago)
Author:
keishi@webkit.org
Message:

2011-05-31 Keishi Hattori <​keishi@webkit.org>

Reviewed by Kent Tamura.

Fix to enable page scroll of select element
​https://bugs.webkit.org/show_bug.cgi?id=53628

Manual test: select-page-scroll.html

  • manual-tests/select-page-scroll.html: Added.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
Location:
trunk/Source/WebCore
Files:
1 added
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r87771 r87773  
     12011-05-31  Keishi Hattori  <keishi@webkit.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Fix to enable page scroll of select element
     6        https://bugs.webkit.org/show_bug.cgi?id=53628
     7
     8        Manual test: select-page-scroll.html
     9
     10        * manual-tests/select-page-scroll.html: Added.
     11        * rendering/RenderListBox.cpp:
     12        (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
     13
    1142011-05-31  Yong Li  <yoli@rim.com>
    215

  • trunk/Source/WebCore/rendering/RenderListBox.cpp

    r87443 r87773  
    238238        bool enabled = numVisibleItems() < numItems();
    239239        m_vBar->setEnabled(enabled);
    240         m_vBar->setSteps(1, min(1, numVisibleItems() - 1), itemHeight);
     240        m_vBar->setSteps(1, max(1, numVisibleItems() - 1), itemHeight);
    241241        m_vBar->setProportion(numVisibleItems(), numItems());
    242242        if (!enabled)
Note: See TracChangeset for help on using the changeset viewer.