Changeset 87878 in webkit

Timestamp:

Jun 1, 2011 9:51:08 PM (13 years ago)

Author:

leviw@chromium.org

Message:

2011-06-01 Levi Weintraub <​leviw@chromium.org>

Reviewed by Hajime Morita.

Add IntPoint + IntPoint operator
​https://bugs.webkit.org/show_bug.cgi?id=61876

Adding an operator+ convenience method to IntPoint that sums two points
and returns the result as an IntPoint. Changing doImageDrag to use it
as a proof of concept.

No new tests since there is no change in behavior.

• page/DragController.cpp: (WebCore::DragController::doImageDrag):
• platform/graphics/IntPoint.h: (WebCore::operator+):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DragController.cpp (modified) (1 diff)
• platform/graphics/IntPoint.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-01  Levi Weintraub  <leviw@chromium.org>
+
+        Reviewed by Hajime Morita.
+
+        Add IntPoint + IntPoint operator
+        https://bugs.webkit.org/show_bug.cgi?id=61876
+
+        Adding an operator+ convenience method to IntPoint that sums two points
+        and returns the result as an IntPoint. Changing doImageDrag to use it
+        as a proof of concept.
+
+        No new tests since there is no change in behavior.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::doImageDrag):
+        * platform/graphics/IntPoint.h:
+        (WebCore::operator+):
+
 2011-06-01  Jaehun Lim  <ljaehun.lim@samsung.com>
 

trunk/Source/WebCore/page/DragController.cpp

@@ -826 +826 @@
     }
 
-    dragImageOffset.setX(mouseDownPoint.x() + origin.x());
-    dragImageOffset.setY(mouseDownPoint.y() + origin.y());
+    dragImageOffset = mouseDownPoint + origin;
     doSystemDrag(dragImage, dragImageOffset, dragOrigin, clipboard, frame, false);
 

trunk/Source/WebCore/platform/graphics/IntPoint.h

@@ -188 +188 @@
 }
 
+inline IntPoint operator+(const IntPoint& a, const IntPoint& b)
+{
+    return IntPoint(a.x() + b.x(), a.y() + b.y());
+}
+
 inline IntSize operator-(const IntPoint& a, const IntPoint& b)
 {