Changeset 87896 in webkit
- Timestamp:
- Jun 2, 2011 5:00:55 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r87895 r87896 1 2011-06-02 Naiem Shaik <naiem.shaik@gmail.com> 2 3 Reviewed by Kent Tamura. 4 5 Fixing invalid value being returned for default checkbox and radio state 6 https://bugs.webkit.org/show_bug.cgi?id=61674 7 8 As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and 9 http://www.w3.org/TR/html5/number-state.html#radio-button-state: 10 The value IDL attribute is in mode default/on: 11 If the element has a value attribute, it must return that attribute's 12 value; otherwise, it must return the string "on". 13 Currently default value is empty string;Default value of Radio button 14 and checkbox should be "on" 15 This works as per spec in IE9,Firefox and Opera 16 17 * fast/forms/checkbox-default-value-expected.txt: Added. 18 * fast/forms/checkbox-default-value.html: Added. 19 * fast/forms/radio-default-value-expected.txt: Added. 20 * fast/forms/radio-default-value.html: Added. 21 1 22 2011-06-02 Mario Sanchez Prada <msanchez@igalia.com> 2 23 -
trunk/Source/WebCore/ChangeLog
r87891 r87896 1 2011-06-02 Naiem Shaik <naiem.shaik@gmail.com> 2 3 Reviewed by Kent Tamura. 4 5 Fixing invalid value being returned for default checkbox and radio state 6 https://bugs.webkit.org/show_bug.cgi?id=61674 7 8 As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and 9 http://www.w3.org/TR/html5/number-state.html#radio-button-state: 10 The value IDL attribute is in mode default/on: 11 If the element has a value attribute, it must return that attribute's 12 value; otherwise, it must return the string "on". 13 Currently default value is empty string;Default value of Radio button 14 and checkbox should be "on".Changed fallbackValue function to return the same 15 This works as per spec in IE9,Firefox and Opera 16 17 Tests: fast/forms/checkbox-default-value.html 18 fast/forms/radio-default-value.html 19 20 * html/BaseCheckableInputType.cpp: 21 (WebCore::BaseCheckableInputType::fallbackValue): 22 1 23 2011-06-02 Kent Tamura <tkent@chromium.org> 2 24 -
trunk/Source/WebCore/html/BaseCheckableInputType.cpp
r74895 r87896 95 95 String BaseCheckableInputType::fallbackValue() 96 96 { 97 return element()->checked() ? "on" : "";97 return "on"; 98 98 } 99 99
Note: See TracChangeset
for help on using the changeset viewer.