Changeset 87988 in webkit

Timestamp:

Jun 2, 2011 7:34:31 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-02 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium][V8] Add trace events for timer fires and event listener dispatches
​https://bugs.webkit.org/show_bug.cgi?id=61977

Adds TRACE_EVENT macro around timer and event listener dispatches. When tracing (a chromium feature) is
enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
is traced. When tracing is disabled, this macro does nothing useful. Trace points are very cheap when tracing
is disabled so this should have no performance impact for non-developers.

• bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
• bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::callListenerFunction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/ScheduledAction.cpp (modified) (2 diffs)
• bindings/v8/V8EventListener.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-02  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [chromium][V8] Add trace events for timer fires and event listener dispatches
+        https://bugs.webkit.org/show_bug.cgi?id=61977
+
+        Adds TRACE_EVENT macro around timer and event listener dispatches.  When tracing (a chromium feature) is
+        enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
+        is traced.  When tracing is disabled, this macro does nothing useful.  Trace points are very cheap when tracing
+        is disabled so this should have no performance impact for non-developers.
+
+        * bindings/v8/ScheduledAction.cpp:
+        (WebCore::ScheduledAction::execute):
+        * bindings/v8/V8EventListener.cpp:
+        (WebCore::V8EventListener::callListenerFunction):
+
 2011-06-02  John Bates  <jbates@google.com>
 

trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp

@@ -35 +35 @@
 #include "ScriptExecutionContext.h"
 #include "ScriptSourceCode.h"
+#include "TraceEvent.h"
 
 #include "V8Binding.h"
@@ -111 +112 @@
         return; // JS may not be enabled.
 
+    TRACE_EVENT("ScheduledAction::execute", this, 0);
+
     v8::Context::Scope scope(v8Context);
 

trunk/Source/WebCore/bindings/v8/V8EventListener.cpp

@@ -32 +32 @@
 #include "V8EventListener.h"
 
+#include "TraceEvent.h"
 #include "V8Proxy.h"
 
@@ -74 +75 @@
     v8::Handle<v8::Value> parameters[1] = { jsEvent };
 
+    TRACE_EVENT("V8EventListener::callListenerFunction", this, 0);
+
     if (V8Proxy* proxy = V8Proxy::retrieve(context))
         return proxy->callFunction(handlerFunction, receiver, 1, parameters);